[WIP] add nerdctl ci minimal support

[yankay]

Add basic ci to test that kind can create clusters with nerdctl , and using the docker provider.

The issue: #2317 (comment)

The PR is wating: containerd/nerdctl#2600

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yankay
Once this PR has been reviewed and has the lgtm label, please assign bentheelder for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[neolit123]

looking at the existing workflows it seems acceptable to test providers, but unclear whether wrapping CLI tools like nerdctl should be tested.

it's always better to log an issue and discuss the proposal there, before sending the PR.

my vote for this change is +0.

[AkihiroSuda]

You want to wait for nerdctl v1.7
(ETA: by the end of this week)

[yankay]

Thanks @AkihiroSuda

it's waiting for the nerdctl v1.7.

[AkihiroSuda]

https://github.com/containerd/nerdctl/releases/tag/v1.7.0

[AkihiroSuda]

kind should support a custom Docker path via $DOCKER

[yankay]

I want to make kind support the custom binary name in the next .

The kind is hardcoded docker in the provider. for example:
https://github.com/kubernetes-sigs/kind/blob/v0.20.0/pkg/cluster/internal/providers/docker/provision.go#L314

So it use the symbolic link now.

[AkihiroSuda]

Why not 22.04 ?

[yankay]

I'll try to upgrade them at #3409
If it merged, it'll be updated

[AkihiroSuda]

Can we support rootless too?

[yankay]

Thanks @AkihiroSuda

The rootless mode support has been added to the 'work items' at : #2317 (comment)

Could I provide it in another PR, so that this PR will not be too large ?

[yankay]

looking at the existing workflows it seems acceptable to test providers, but unclear whether wrapping CLI tools like nerdctl should be tested.

it's always better to log an issue and discuss the proposal there, before sending the PR.

my vote for this change is +0.

Thanks @neolit123 for the PR review. :-)

I've log the issue at the #2317 (comment) to proposal.
So we can disscuss there.

Best Regards.

[AkihiroSuda]

kind/pkg/cluster/provider.go

Lines 99 to 122 in a9fbf70

	// DetectNodeProvider allows callers to autodetect the node provider
	// *without* fallback to the default.
	//
	// Pass the returned ProviderOption to NewProvider to pass the auto-detect Docker
	// or Podman option explicitly (in the future there will be more options)
	//
	// NOTE: The kind *cli* also checks `KIND_EXPERIMENTAL_PROVIDER` for "podman" or
	// "docker" currently and does not auto-detect / respects this if set.
	//
	// This will be replaced with some other mechanism in the future (likely when
	// podman support is GA), in the meantime though your tool may wish to match this.
	//
	// In the future when this is not considered experimental,
	// that logic will be in a public API as well.
	func DetectNodeProvider() (ProviderOption, error) {
	// auto-detect based on each node provider's IsAvailable() function
	if docker.IsAvailable() {
	return ProviderWithDocker(), nil
	}
	if podman.IsAvailable() {
	return ProviderWithPodman(), nil
	}
	return nil, errors.WithStack(NoNodeProviderDetectedError)
	}

kind/pkg/cluster/internal/providers/docker/util.go

Lines 26 to 34 in a9fbf70

	// IsAvailable checks if docker is available in the system
	func IsAvailable() bool {
	cmd := exec.Command("docker", "-v")
	lines, err := exec.OutputLines(cmd)
	if err != nil || len(lines) != 1 {
	return false
	}
	return strings.HasPrefix(lines[0], "Docker version")
	}

This check has to be modified, otherwise it choose Podman, not nerdctl

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yankay]

close by #3429