Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: upgrade nerdctl to v2 #3850

Merged

Conversation

tao12345666333
Copy link
Member

@tao12345666333 tao12345666333 commented Jan 19, 2025

This release of nerdctl is expected to be used with containerd v1.6, v1.7, or v2.0.
https://github.com/containerd/nerdctl/releases/tag/v2.0.2

The nerdctl v2.x is also expected to be compatible with containerd v2.

This pull request includes updates to version numbers for dependencies in the nerdctl GitHub workflow and the default base image in the nodeimage package.

Version updates:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 19, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 19, 2025
@tao12345666333
Copy link
Member Author

The CI failure was due to using cat to read the configuration in this directory within the workflow. However, a default directory was added in v2.

I will fix it.

sudo tree  /etc/cni/net.d/
/etc/cni/net.d/
├── default
│   └── nerdctl-kind.conflist
└── nerdctl-bridge.conflist

2 directories, 2 files

@@ -91,7 +91,7 @@ jobs:
- name: Export logs
if: always()
run: |
sudo cat /etc/cni/net.d/*
sudo find /etc/cni/net.d/ -type f -exec sh -c 'echo "{}" && cat "{}"' \;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have explained here #3850 (comment) that the previous method would lead to errors.

failed job: https://github.com/kubernetes-sigs/kind/actions/runs/12855249247/job/35840567917

Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@BenTheElder
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2025
@BenTheElder
Copy link
Member

/lgtm
thank you!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2025
@k8s-ci-robot k8s-ci-robot merged commit 5fcf39d into kubernetes-sigs:main Jan 23, 2025
21 checks passed
@tao12345666333 tao12345666333 deleted the upgrade-nerdctl-v2 branch January 25, 2025 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants