-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: upgrade nerdctl to v2 #3850
test: upgrade nerdctl to v2 #3850
Conversation
The CI failure was due to using cat to read the configuration in this directory within the workflow. However, a default directory was added in v2. I will fix it.
|
@@ -91,7 +91,7 @@ jobs: | |||
- name: Export logs | |||
if: always() | |||
run: | | |||
sudo cat /etc/cni/net.d/* | |||
sudo find /etc/cni/net.d/ -type f -exec sh -c 'echo "{}" && cat "{}"' \; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have explained here #3850 (comment) that the previous method would lead to errors.
failed job: https://github.com/kubernetes-sigs/kind/actions/runs/12855249247/job/35840567917
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
253e2b2
to
a2cb274
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, tao12345666333 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
The nerdctl v2.x is also expected to be compatible with containerd v2.
This pull request includes updates to version numbers for dependencies in the
nerdctl
GitHub workflow and the default base image in thenodeimage
package.Version updates:
.github/workflows/nerdctl.yaml
: UpdatedNERDCTL_VERSION
from "1.7.4" to "2.0.2".*pkg/build/nodeimage/defaults.go
: UpdatedDefaultBaseImage
from "docker.io/kindest/base:v20241212-9f82dd49" to "docker.io/kindest/base:v20250117-f528b021".