add environment defaulting with GOFLAGS=-tags=providerless to docker … #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…build to get smaller kubernetes builds
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
BenTheElder
commented
Aug 27, 2019
| // leverage in-tree-cloud-provider-free builds by default | ||
| // https://github.com/kubernetes/kubernetes/pull/80353 | ||
| "GOFLAGS=-tags=providerless", | ||
| }, |
There was a problem hiding this comment.
these are all just hoisted up, except "GOFLAGS=-tags=providerless", which is new.
k8s-ci-robot
added
the
lgtm
|
Adding a note for anyone finding this later (we'll put something similar in the release notes)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…build to get smaller kubernetes builds
added some more notes to the comments and minor formatting cleanup.
see: kubernetes/kubernetes#80353 kubernetes/enhancements#1180