Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated TODO comment #777

Merged
merged 1 commit into from
May 11, 2022

Conversation

JohnTitor
Copy link
Contributor

This comment was written in fa9866f, now we don't have these two funcs and the architecture seems fine.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 11, 2022
@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 11, 2022
@ahmetb
Copy link
Member

ahmetb commented May 11, 2022

/lgtm
/approve
Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, JohnTitor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit d3c7635 into kubernetes-sigs:master May 11, 2022
@JohnTitor JohnTitor deleted the outdated-comment branch May 11, 2022 16:05
@JohnTitor
Copy link
Contributor Author

@ahmetb Hey, by the way, I'm interested in sig-cli and krew itself. Could you sponsor me to join? I have one sponsor now.

@ahmetb
Copy link
Member

ahmetb commented May 12, 2022

I personally expect some medium to long-term contribution cadence rather than a short term commit burst.

A lot of the Krew work today happens in krew-index as the source code has been fairly stable for some years. That work is largely manual and requires understanding the plugin ecosystem, what do we allow and whatnot.

While I appreciate you going through the code and fixing up a ton of stuff, I also need to make sure this is not a temporary thing to sponsor. :)

@ahmetb
Copy link
Member

ahmetb commented May 12, 2022

^ btw here I mostly mean sponsorship for being a Krew maintainer, sig-cli member sponsorship can be easier and I can vouch for that. But what are you actually getting out of it. :)

@JohnTitor
Copy link
Contributor Author

Makes sense to me! I asked because sig-cli and krew are some of my interests in joining and contributing to the community. So, I'd like to see how things (krew and other CLIs) are going and get my feet wetter (and find what's the best way to contribute to krew in the medium term) as a sig-cli member (half of my reasons is to get rid of needs-ok-to-test on the kubernetes org and it needs to join the org and to be sponsored by some members, so I wanted to use this opportunity to contribute to more SIGs).
For now, I'm going to ask for sig-cli sponsorship here. Thanks for the detailed response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants