This repository has been archived by the owner on May 25, 2023. It is now read-only.
Rename PrioritizeFn to NodeOrderFn #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
animeshsingh
suggested changes
Mar 8, 2019
pkg/scheduler/conf/scheduler_conf.go
Outdated
| // PriortizeDisabled defines whether PriorityFn is disabled | ||
| PriortizeDisabled bool `yaml:"disablePrioritize"` | ||
| // NodeOrderDisabled defines whether PriorityFn is disabled | ||
| NodeOrderDisabled bool `yaml:"disablePrioritize"` |
There was a problem hiding this comment.
This should say disableNodeOrder, both in comment and yaml?
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k82cn, thandayuthapani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@thandayuthapani we also need to cherry pick this to release-0.4 |
This was referenced Mar 8, 2019
k8s-ci-robot
added a commit
that referenced
this pull request
Mar 9, 2019
…ream-release-0.4 Automated cherry pick of #625: Change Plugin name prioritize to nodeOrder
kevin-wangzefeng
pushed a commit
to kevin-wangzefeng/scheduler
that referenced
this pull request
Jun 28, 2019
Rename PrioritizeFn to NodeOrderFn
kevin-wangzefeng
pushed a commit
to kevin-wangzefeng/scheduler
that referenced
this pull request
Jun 28, 2019
Rename PrioritizeFn to NodeOrderFn
kevin-wangzefeng
pushed a commit
to kevin-wangzefeng/scheduler
that referenced
this pull request
Jun 28, 2019
Rename PrioritizeFn to NodeOrderFn
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Renamed Prioritize Plugin to NodeOrder Plugin
Which issue(s) this PR fixes:
Fixes # #624