Add helm hook crd-install to fix helm install error #631
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
| @@ -2,6 +2,8 @@ apiVersion: apiextensions.k8s.io/v1beta1 | |||
| kind: CustomResourceDefinition | |||
| metadata: | |||
| name: queues.scheduling.incubator.k8s.io | |||
| annotations: | |||
| "helm.sh/hook": "crd-install" | |||
There was a problem hiding this comment.
can you also help to add this hook for PodGroup?
There was a problem hiding this comment.
The YAML files in the chart do not use PodGroup, so it seems unnecessary? I'll add it if needed :)
There was a problem hiding this comment.
Added it in case that some logic(e.g. logic in the kube-batch deployment) depends on it.
There was a problem hiding this comment.
thanks :) Just in case we add some other dependency on that.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hex108, k82cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Add helm hook crd-install to fix helm install error
Add helm hook crd-install to fix helm install error
Add helm hook crd-install to fix helm install error
What this PR does / why we need it:
There is an error when running
helm install $GOPATH/src/github.com/kubernetes-sigs/kube-batch/deployment/kube-batch --namespace kube-system.Error message:
It is because helm does not guarantee that
deployment/kube-batch/templates/scheduling_v1alpha1_queue.yamlwill be executed beforedeployment/kube-batch/templates/default.yaml. However we could add a helm hookcrd-installto guarantee it.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: