Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a command line option to pass the node name #43

Closed
aojea opened this issue Jun 25, 2024 · 0 comments · Fixed by #44
Closed

Use a command line option to pass the node name #43

aojea opened this issue Jun 25, 2024 · 0 comments · Fixed by #44
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@aojea
Copy link
Contributor

aojea commented Jun 25, 2024

The node name is passed as an environment variable

It would still be better for it to be a command-line option, even if it's required. Required environment variables are terrible.

Originally posted by @danwinship in #39 (comment)
@aojea aojea added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jun 25, 2024
This was referenced Jun 25, 2024
Merged
Merged
@aojea aojea closed this as completed in #44 Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

don't use obscure env variables and use flags aojea/kube-network-policies
1 participant
@aojea