don't use obscure env variables and use flags

[aojea]

Let's do the things the right way

Fixes: #43

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [aojea]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[aojea]

/assign @danwinship

[aojea]

the main problem because I added the env variables is because I was not sure you can do this, of using the env variable as the flag value and I was too lazy ... now that you mentioned I can see this is exactly how most people do https://grep.app/search?q=hostname-override%3D%24&filter[lang][0]=YAML

[aojea]

ups , something is wrong

2024-06-26T10:58:00.54696576Z stderr F I0626 10:58:00.546903       1 controller.go:89] Creating controller: networkpolicy.Config{FailOpen:false, AdminNetworkPolicy:false, BaselineAdminNetworkPolicy:false, QueueID:100, NodeName:"${my_node_name}"}

[aojea]

ok, embarrassing things https://kubernetes.io/docs/tasks/inject-data-application/define-command-argument-container/#use-environment-variables-to-define-arguments

[danwinship]

/lgtm
/hold
if you want to update the error message but maybe that was intentional

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[aojea]

/lgtm /hold if you want to update the error message but maybe that was intentional

/hold cancel

fixed the env variable problem and added the error to the log, once CI passes we should be good to go and I fix existing release