Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add admin and baseline network policy #9

Merged
merged 11 commits into from
Apr 25, 2024
Merged

add admin and baseline network policy #9

merged 11 commits into from
Apr 25, 2024

Conversation

aojea
Copy link
Contributor

@aojea aojea commented Apr 21, 2024

It looks relatively simple to implement

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 21, 2024
@k8s-ci-robot k8s-ci-robot requested a review from danwinship April 21, 2024 14:51
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from thockin April 21, 2024 14:51
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 21, 2024
@aojea
Copy link
Contributor Author

aojea commented Apr 21, 2024

/cc @danwinship @tssurya @npinaeva

@aojea aojea force-pushed the admin branch 2 times, most recently from a37eada to 6bdb493 Compare April 23, 2024 18:40
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 23, 2024
@aojea aojea force-pushed the admin branch 2 times, most recently from 211635d to 57fb732 Compare April 24, 2024 07:59
npinaeva
npinaeva reviewed Apr 24, 2024
View reviewed changes
pkg/networkpolicy/adminnetworkpolicy.go Outdated Show resolved Hide resolved
pkg/networkpolicy/adminnetworkpolicy.go Outdated Show resolved Hide resolved
@aojea aojea force-pushed the admin branch 3 times, most recently from d4ad191 to f228da4 Compare April 24, 2024 10:29
@aojea aojea force-pushed the admin branch 2 times, most recently from da985ab to 7c36002 Compare April 24, 2024 17:42
@aojea aojea changed the title [WIP] add admin network policy add admin network policy Apr 24, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 24, 2024
@aojea aojea force-pushed the admin branch 4 times, most recently from 780bff1 to a468353 Compare April 24, 2024 20:01
@aojea aojea changed the title add admin network policy add admin and baselina network policy Apr 25, 2024
@aojea aojea changed the title add admin and baselina network policy add admin and baseline network policy Apr 25, 2024
@aojea aojea merged commit c677550 into kubernetes-sigs:main Apr 25, 2024
8 of 9 checks passed
@aojea aojea mentioned this pull request Apr 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npinaeva npinaeva npinaeva left review comments

@tssurya tssurya tssurya left review comments

@danwinship danwinship Awaiting requested review from danwinship

@thockin thockin Awaiting requested review from thockin

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aojea @k8s-ci-robot @tssurya @npinaeva