Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump k8s to 1.21 #160

Merged
merged 1 commit into from
Jun 30, 2021
Merged

bump k8s to 1.21 #160

merged 1 commit into from
Jun 30, 2021

Conversation

varshaprasad96
Copy link
Member

@varshaprasad96 varshaprasad96 commented Jun 15, 2021 •
edited
Loading

Co-authored-by: atoato88 akihito-inou@nec.com

What this PR does / why we need it:
This PR bumps controller runtime to 0.9.0 and k8s dependencies to 1.21.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Jun 15, 2021
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 15, 2021
@varshaprasad96 varshaprasad96 mentioned this pull request Jun 21, 2021
Closed
@varshaprasad96
Copy link
Member Author

Blocked by kubernetes-sigs/controller-runtime#1560

@varshaprasad96 varshaprasad96 mentioned this pull request Jun 22, 2021
Merged
@atoato88
Copy link
Contributor

I updated some codes on my branch for passing tests with this PR.
With following changes, I confirmed that hask/ci/teset.sh pass all tests in my local env.
atoato88@7ac8645

@varshaprasad96 varshaprasad96 force-pushed the bump/k8s-1.21 branch 2 times, most recently from 936fbe6 to 38d7807 Compare June 22, 2021 16:51
@varshaprasad96
Copy link
Member Author

@atoato88 Thanks a lot! I have included the changes to this PR and added you as a co-author if that's fine. If you would like to open another PR, I can close this one.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 22, 2021
estroz
estroz approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 22, 2021
@atoato88
Copy link
Contributor

... If you would like to open another PR, I can close this one.

@varshaprasad96
Thank you to add me as co-author. It's OK to go forward on this PR 😄
"pull-declarative-test" CI job was passed 🎉

camilamacedo86
camilamacedo86 approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is great for me 👍 Good work

@camilamacedo86
Copy link
Member

/approve

@varshaprasad96
Copy link
Member Author

@Liujingfang1 @justinsb - pinging here. Would be helpful to have this in!

@estroz estroz mentioned this pull request Jun 30, 2021
Merged
@varshaprasad96
bump k8s to 1.21
feae58d 
Co-authoured-by: atoato88 <akihito-inou@nec.com>
Signed-off-by: varshaprasad96 <varshaprasad96@gmail.com>
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jun 30, 2021
@estroz
Copy link
Contributor

estroz commented Jun 30, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, estroz, varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f77bb49 into kubernetes-sigs:master Jun 30, 2021
@atoato88 atoato88 mentioned this pull request Aug 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estroz estroz estroz approved these changes

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@atoato88 atoato88 Awaiting requested review from atoato88

@Liujingfang1 Liujingfang1 Awaiting requested review from Liujingfang1

Assignees

@estroz estroz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@varshaprasad96 @atoato88 @camilamacedo86 @estroz @k8s-ci-robot