Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix namespace setting with direct applier #173

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Fix namespace setting with direct applier #173

merged 1 commit into from
Sep 14, 2021

Conversation

justinsb
Copy link
Contributor

The direct-applier was not setting the namespace correctly; we reuse
the SetNamespace visitor to do so.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 28, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Aug 28, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 28, 2021
@justinsb justinsb mentioned this pull request Aug 28, 2021
Closed
@justinsb justinsb force-pushed the set_namespace_direct_applier branch from 5ec2f10 to a3bf49d Compare August 28, 2021 21:30
@atoato88
Copy link
Contributor

atoato88 commented Sep 7, 2021

Codes for adding Namespace is LGTM.
And I commented on manifest validation above.

@atoato88 atoato88 mentioned this pull request Sep 10, 2021
Closed
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 11, 2021
@justinsb @atoato88
Fix namespace setting with direct applier
198f997 
The direct-applier was not setting the namespace correctly; we reuse
the SetNamespace visitor to do so.

Co-authored-by: atoato88 <akihito-inou@nec.com>
@atoato88
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2021
@k8s-ci-robot k8s-ci-robot merged commit 8abbabd into kubernetes-sigs:master Sep 14, 2021
@atoato88 atoato88 mentioned this pull request Sep 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoato88 atoato88 atoato88 left review comments

@Liujingfang1 Liujingfang1 Awaiting requested review from Liujingfang1

Assignees

@atoato88 atoato88

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinsb @k8s-ci-robot @atoato88