Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make atoato88 an approver #177

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

justinsb
Copy link
Contributor

atoato88 has demonstrated deep understanding of the code, and has a
track record of participation. Thank you atoato88!

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Sep 11, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 11, 2021
@justinsb
Copy link
Contributor Author

@atoato88 would you like to become an approver for the project? You have a long track record here that justifies it IMO.

/assign johnsonj for approval

/hold for atoato88 to accept

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2021
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Sep 11, 2021
@atoato88
Copy link
Contributor

I'm so appreciate.
Yes please😄

Besides here, I would like to continue reviewing cluster-addons also. 😉

@stealthybox
Copy link

You have a long track record here

+1

Thanks for your efforts here @atoato88

@johnsonj
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2021
@johnsonj
Copy link
Contributor

johnsonj commented Sep 14, 2021

/approve

Thank you @atoato88 for your continued, high quality contributions and being part of the project!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnsonj, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justinsb
Copy link
Contributor Author

Looks like consensus - thank you all and @atoato88 :-)

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit 97e84c6 into kubernetes-sigs:master Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants