Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Support adding a WIP prefix to the title as understood by prow #26

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

Adirio
Copy link
Contributor

@Adirio Adirio commented Nov 23, 2020

Description

Prow adds the label hold/work-in-progress in case a WIP (case insensitive, allowing wrapping non-word characters) prefix is found at the PR title. Allow the title verifier to accept these prefixes without resulting in errors.

Signed-off-by: Adrian Orive <adrian.orive.oneca@gmail.com>
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 23, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 23, 2020
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no strong opinion here. It shows fine we allow WIP for me. 👍
However, I'd like to see other positions as well. So, only

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Adirio, camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Adirio,camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vincepri
Copy link
Member

I don't know if this is actually needed? If a PR is merged it probably doesn't have WIP in the title, the release notes tool only looks at the merge commits that have been merged into the mainline branch, it doesn't actually query the APIs

@Adirio
Copy link
Contributor Author

Adirio commented Nov 30, 2020

@vincepri

I don't know if this is actually needed? If a PR is merged it probably doesn't have WIP in the title, the release notes tool only looks at the merge commits that have been merged into the mainline branch, it doesn't actually query the APIs

While it is found in the notes package, the function is actually part of the verify action. As part of #28 I moved it there as at you say it is pretty missleading. What this changes means is that the action won't mark titles starting by WIP or [WIP] as wrong titles if the rest of the title provides a PR type.

@vincepri
Copy link
Member

I see, thank you!

@vincepri
Copy link
Member

LGTM

/assign @DirectXMan12

@DirectXMan12
Copy link
Contributor

hmm... I guess prow prevents us from merging if something is WIP anyway, so it's fine to pass here.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2020
@k8s-ci-robot k8s-ci-robot merged commit 09382ff into kubernetes-sigs:master Dec 2, 2020
@Adirio Adirio deleted the wip-support branch December 2, 2020 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants