-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Support adding a WIP prefix to the title as understood by prow #26
Conversation
Signed-off-by: Adrian Orive <adrian.orive.oneca@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no strong opinion here. It shows fine we allow WIP for me. 👍
However, I'd like to see other positions as well. So, only
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Adirio, camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I don't know if this is actually needed? If a PR is merged it probably doesn't have |
While it is found in the |
I see, thank you! |
LGTM /assign @DirectXMan12 |
hmm... I guess prow prevents us from merging if something is WIP anyway, so it's fine to pass here. /lgtm |
Description
Prow adds the label
hold/work-in-progress
in case aWIP
(case insensitive, allowing wrapping non-word characters) prefix is found at the PR title. Allow the title verifier to accept these prefixes without resulting in errors.