Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For go/v4, remove the option to create v1beta1 CRD and Webhooks #2531

Closed
camilamacedo86 opened this issue Mar 8, 2022 · 4 comments · Fixed by #3032
Closed

For go/v4, remove the option to create v1beta1 CRD and Webhooks #2531

camilamacedo86 opened this issue Mar 8, 2022 · 4 comments · Fixed by #3032
Assignees
@NikhilSharmaWe
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
go/v4

Comments

@camilamacedo86
Copy link
Member

What do you want to happen?

For go/v4, remove the option to create v1beta1 CRD and Webhooks.
These APIs are no longer supported since k8s 1.22 and with versions upper than controller-gen v0.6.2 and controller-runtime v0.9.2. As a workaround to allow users to move forward and not break the backwards compatibility we have been trying to downgrade the versions, see: https://github.com/kubernetes-sigs/kubebuilder/blob/master/pkg/plugins/golang/v3/commons.go#L38

Places that need to be cleaned up for go/v4:

For webhooks

For CRDs

Extra Labels

No response
@camilamacedo86 camilamacedo86 added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 8, 2022
@camilamacedo86 camilamacedo86 added this to the go/v4 milestone Mar 8, 2022
@camilamacedo86 camilamacedo86 added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Mar 8, 2022
@NikhilSharmaWe
Copy link
Member

@camilamacedo86 Could you please explain what we have to do here for removing the option to create v1beta1 CRD and Webhooks.

  • Do we have to just remove these statements you have mentioned in webhook.go and api.go which are setting different flags for webhookVersion and crdVersion ?

@NikhilSharmaWe
Copy link
Member

/assign

@NikhilSharmaWe
Copy link
Member

NikhilSharmaWe commented Mar 18, 2022 •
edited
Loading

@camilamacedo86 Could you please respond to #2531 (comment).

@camilamacedo86 camilamacedo86 mentioned this issue Mar 18, 2022
Closed
@camilamacedo86
Copy link
Member Author

camilamacedo86 commented Mar 18, 2022 •
edited
Loading

Hi @NikhilSharmaWe,

All issues under the milestone https://github.com/kubernetes-sigs/kubebuilder/milestone/26 are breaking changes and can only get done when we do a go/v4 plugin. I created a task for that, see #2547 with all details.

Then, we can apply on this one everything that is under this milestone : https://github.com/kubernetes-sigs/kubebuilder/milestone/26
Also, by default kubebuilder should still scaffold the go/v3 and it will be changed only when go/v4 be promoted to stable.

@NikhilSharmaWe NikhilSharmaWe mentioned this issue Mar 20, 2022
Merged
This was referenced Oct 1, 2022
Merged
Closed
camilamacedo86 added a commit to camilamacedo86/kubebuilder that referenced this issue Oct 1, 2022
@camilamacedo86
Add new Golang base for go/v4-alpha with changes requested by the com…
45ae9ed 
…munity in the layout

- Add a new golang language base plugin (base.go/v4)
- Change the go/v4-alpha plugin to use the new base
- Address the layout changes requirements for go/v4. Now, the api and controllers are under the pkg dir.
- Change the Makefile to install kustomize with go install
- Remove crdVersion and webhook versions that is not supported and should no longer be served.

Closes: kubernetes-sigs#932
Closes: kubernetes-sigs#2531
Closes: kubernetes-sigs#2822
camilamacedo86 added a commit to camilamacedo86/kubebuilder that referenced this issue Oct 1, 2022
@camilamacedo86
Add new Golang base for go/v4-alpha with changes requested by the com…
6b4af1c 
…munity in the layout

- Add a new golang language base plugin (base.go/v4)
- Change the go/v4-alpha plugin to use the new base
- Address the layout changes requirements for go/v4. Now, the api and controllers are under the pkg dir.
- Change the Makefile to install kustomize with go install
- Remove crdVersion and webhook versions that is not supported and should no longer be served.

Closes: kubernetes-sigs#932
Closes: kubernetes-sigs#2531
Closes: kubernetes-sigs#2822
camilamacedo86 added a commit to camilamacedo86/kubebuilder that referenced this issue Oct 1, 2022
@camilamacedo86
Add new Golang base for go/v4-alpha with changes requested by the com…
f77eff9 
…munity in the layout

- Add a new golang language base plugin (base.go/v4)
- Change the go/v4-alpha plugin to use the new base
- Address the layout changes requirements for go/v4. Now, the api and controllers are under the pkg dir.
- Change the Makefile to install kustomize with go install
- Remove crdVersion and webhook versions that is not supported and should no longer be served.

Closes: kubernetes-sigs#932
Closes: kubernetes-sigs#2531
Closes: kubernetes-sigs#2822
camilamacedo86 added a commit to camilamacedo86/kubebuilder that referenced this issue Oct 1, 2022
@camilamacedo86
Add new Golang base for go/v4-alpha with changes requested by the com…
5a32d68 
…munity in the layout

- Add a new golang language base plugin (base.go/v4)
- Change the go/v4-alpha plugin to use the new base
- Address the layout changes requirements for go/v4. Now, the api and controllers are under the pkg dir.
- Change the Makefile to install kustomize with go install
- Remove crdVersion and webhook versions that is not supported and should no longer be served.

Closes: kubernetes-sigs#932
Closes: kubernetes-sigs#2531
Closes: kubernetes-sigs#2822
camilamacedo86 added a commit to camilamacedo86/kubebuilder that referenced this issue Oct 1, 2022
@camilamacedo86
Add new Golang base for go/v4-alpha with changes requested by the com…
cee83dd 
…munity in the layout

- Add a new golang language base plugin (base.go/v4)
- Change the go/v4-alpha plugin to use the new base
- Address the layout changes requirements for go/v4. Now, the api and controllers are under the pkg dir.
- Change the Makefile to install kustomize with go install
- Remove crdVersion and webhook versions that is not supported and should no longer be served.

Closes: kubernetes-sigs#932
Closes: kubernetes-sigs#2531
Closes: kubernetes-sigs#2822
camilamacedo86 added a commit to camilamacedo86/kubebuilder that referenced this issue Oct 1, 2022
@camilamacedo86
Add new Golang base for go/v4-alpha with changes requested by the com…
95f5458 
…munity in the layout

- Add a new golang language base plugin (base.go/v4)
- Change the go/v4-alpha plugin to use the new base
- Address the layout changes requirements for go/v4. Now, the api and controllers are under the pkg dir.
- Change the Makefile to install kustomize with go install
- Remove crdVersion and webhook versions that is not supported and should no longer be served.

Closes: kubernetes-sigs#932
Closes: kubernetes-sigs#2531
Closes: kubernetes-sigs#2822
camilamacedo86 added a commit to camilamacedo86/kubebuilder that referenced this issue Oct 1, 2022
@camilamacedo86
Add new Golang base for go/v4-alpha with changes requested by the com…
f640b40 
…munity in the layout

- Add a new golang language base plugin (base.go/v4)
- Change the go/v4-alpha plugin to use the new base
- Address the layout changes requirements for go/v4. Now, the api and controllers are under the pkg dir.
- Change the Makefile to install kustomize with go install
- Remove crdVersion and webhook versions that is not supported and should no longer be served.

Closes: kubernetes-sigs#932
Closes: kubernetes-sigs#2531
Closes: kubernetes-sigs#2822
camilamacedo86 added a commit to camilamacedo86/kubebuilder that referenced this issue Oct 1, 2022
@camilamacedo86
Add new Golang base for go/v4-alpha with changes requested by the com…
d8b1cbe 
…munity in the layout

- Add a new golang language base plugin (base.go/v4)
- Change the go/v4-alpha plugin to use the new base
- Address the layout changes requirements for go/v4. Now, the api and controllers are under the pkg dir.
- Change the Makefile to install kustomize with go install
- Remove crdVersion and webhook versions that is not supported and should no longer be served.

Closes: kubernetes-sigs#932
Closes: kubernetes-sigs#2531
Closes: kubernetes-sigs#2822
camilamacedo86 added a commit to camilamacedo86/kubebuilder that referenced this issue Oct 1, 2022
@camilamacedo86
Add new Golang base for go/v4-alpha with changes requested by the com…
1910122 
…munity in the layout

- Add a new golang language base plugin (base.go/v4)
- Change the go/v4-alpha plugin to use the new base
- Address the layout changes requirements for go/v4. Now, the api and controllers are under the pkg dir.
- Change the Makefile to install kustomize with go install
- Remove crdVersion and webhook versions that is not supported and should no longer be served.

Closes: kubernetes-sigs#932
Closes: kubernetes-sigs#2531
Closes: kubernetes-sigs#2822
camilamacedo86 added a commit to camilamacedo86/kubebuilder that referenced this issue Oct 1, 2022
@camilamacedo86
Add new Golang base for go/v4-alpha with changes requested by the com…
c11164a 
…munity in the layout

- Add a new golang language base plugin (base.go/v4)
- Change the go/v4-alpha plugin to use the new base
- Address the layout changes requirements for go/v4. Now, the api and controllers are under the pkg dir.
- Change the Makefile to install kustomize with go install
- Remove crdVersion and webhook versions that is not supported and should no longer be served.

Closes: kubernetes-sigs#932
Closes: kubernetes-sigs#2531
Closes: kubernetes-sigs#2822
camilamacedo86 added a commit to camilamacedo86/kubebuilder that referenced this issue Oct 1, 2022
@camilamacedo86
Add new Golang base for go/v4-alpha with changes requested by the com…
63fab3d 
…munity in the layout

- Add a new golang language base plugin (base.go/v4)
- Change the go/v4-alpha plugin to use the new base
- Address the layout changes requirements for go/v4. Now, the api and controllers are under the pkg dir.
- Change the Makefile to install kustomize with go install
- Remove crdVersion and webhook versions that is not supported and should no longer be served.

Closes: kubernetes-sigs#932
Closes: kubernetes-sigs#2531
Closes: kubernetes-sigs#2822
@camilamacedo86 camilamacedo86 mentioned this issue Oct 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NikhilSharmaWe NikhilSharmaWe

Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
go/v4
2 participants
@camilamacedo86 @NikhilSharmaWe