Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardization of Logging using logrus #3557

Closed
camilamacedo86 opened this issue Aug 25, 2023 · 2 comments · Fixed by #3571
Closed

Standardization of Logging using logrus #3557

camilamacedo86 opened this issue Aug 25, 2023 · 2 comments · Fixed by #3571
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@camilamacedo86
Copy link
Member

What do you want to happen?

We aim to ensure consistent usage of the logrus library ("github.com/sirupsen/logrus") throughout our codebase. There are instances where other methods like fmt.Println() have been used for logging, which need to be addressed to maintain consistency and improve the user experience (UX).

Reference PR for context: kubebuilder#3556.

Objectives:

  • Identify and replace non-standard logging mechanisms (e.g., fmt.Println()) with appropriate logrus methods.
  • Ensure that logs use the correct severity level (log.INFO, log.WARN, etc.) that aligns with the context of the message.

Recommendation:

To facilitate easier code review and integration, it's advised to break down the implementation into multiple smaller PRs rather than one large PR.

Extra Labels

/kind cleanup

@camilamacedo86 camilamacedo86 added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 25, 2023
@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 25, 2023
@camilamacedo86 camilamacedo86 added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Aug 25, 2023
@lowang-bh
Copy link
Member

/assign

@camilamacedo86
Copy link
Member Author

It seems that a point still missing which is: https://github.com/kubernetes-sigs/kubebuilder/blob/master/pkg/plugin/util/exec.go#L31

However, it seems also fine to do that in a follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
3 participants