-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ : Standardization of Logs using Library logrus ( replace of fmt.Print ) #3571
Conversation
Welcome @lowang-bh! |
Hi @lowang-bh. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lowang-bh,
Thank you for your contribution.
It seems that a point still missing which is: https://github.com/kubernetes-sigs/kubebuilder/blob/master/pkg/plugin/util/exec.go#L31
However, it seems also fine to do that in a follow up.
PS.: Note that I updated the title because this change affects user so we cannot use the 🌱 and it should be in the release notes.
Tested locally:
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See that it is not passing in two tests.
Could you please rebase it with the master and ensure that you run make generate
to properly updated the samples under the testdata so that we can move forward here?
Signed-off-by: lowang-bh <lhui_wang@163.com>
Hi, I have updated it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also want to update here:
some print is used to interact with terminal user, so I didn't replace those. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approved
Thank you for your great work 🥇
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, lowang-bh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #3557