Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: ignore #1600

Closed
wants to merge 1 commit into from
Closed

WIP: ignore #1600

wants to merge 1 commit into from

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Jul 19, 2020 •
edited
Loading

WIP

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from droot and mengqiy July 19, 2020 13:28
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2020
@camilamacedo86 camilamacedo86 changed the title envtest setup without additional bins to envtest envtest setup without additional k8s binaries Jul 19, 2020
@camilamacedo86 camilamacedo86 changed the title envtest setup without additional k8s binaries envtest setup without additional k8s binaries (v3 only) Jul 19, 2020
@camilamacedo86
Copy link
Member Author

/assign @DirectXMan12
/assign @joelanford

This was referenced Jul 19, 2020
Closed
Closed
@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-e2e-k8s-1-17-0

@camilamacedo86 camilamacedo86 changed the title envtest setup without additional k8s binaries (v3 only) envtest setup using k8s binaries from the project (v3 only) Jul 19, 2020
@camilamacedo86 camilamacedo86 force-pushed the solve-test-env branch 3 times, most recently from 3b7a8bc to 43bbaa0 Compare July 19, 2020 20:50
estroz
estroz suggested changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@estroz estroz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it is sufficient to have this script in this or the controller-runtime repo and add something like the following to docs:

$ curl -sSLo install-envtest-bins.sh https://raw.githubusercontent.com/kubernetes-sigs/kubebuilder/master/scripts/install-envtest-bins.sh
$ chmod +x install-envtest-bins.sh
$ ./install-envtest-bins.sh

@camilamacedo86

This comment has been minimized.

Sign in to view
@camilamacedo86 camilamacedo86 changed the title envtest setup using k8s binaries from the project (v3 only) wip: envtest setup using k8s binaries from the project (v3 only) Jul 20, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2020
@pwittrock
Copy link
Contributor

pwittrock commented Jul 23, 2020 •
edited
Loading

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2020
@pwittrock
Copy link
Contributor

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2020
@estroz estroz mentioned this pull request Jul 23, 2020
Merged
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2020
@camilamacedo86 camilamacedo86 mentioned this pull request Jul 24, 2020
Merged
@camilamacedo86 camilamacedo86 changed the title wip: new target to setup envtest using k8s binaries (v3 only) new target to setup envtest using k8s binaries (v3 only) Jul 25, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 25, 2020
@camilamacedo86
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2020
@camilamacedo86
Copy link
Member Author

/hold
i will be working on it.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 30, 2020
@camilamacedo86 camilamacedo86 changed the title new target to setup envtest using k8s binaries (v3 only) WIP : new target to setup envtest using k8s binaries (v3 only) Jul 30, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 30, 2020
@camilamacedo86 camilamacedo86 changed the title WIP : new target to setup envtest using k8s binaries (v3 only) new target to setup envtest using k8s binaries (v3 only) Aug 1, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 1, 2020
@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-test

@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-e2e-k8s-1-17-0

@camilamacedo86 camilamacedo86 changed the title new target to setup envtest using k8s binaries (v3 only) WIP: new target to setup envtest using k8s binaries (v3 only) Aug 1, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 1, 2020
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 2, 2020
@k8s-ci-robot
Copy link
Contributor

@camilamacedo86: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubebuilder-e2e-k8s-1-14-1 7a83e2f link /test pull-kubebuilder-e2e-k8s-1-14-1
pull-kubebuilder-e2e-k8s-1-15-3 7a83e2f link /test pull-kubebuilder-e2e-k8s-1-15-3
pull-kubebuilder-test 3d40d37 link /test pull-kubebuilder-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@camilamacedo86 camilamacedo86 changed the title WIP: new target to setup envtest using k8s binaries (v3 only) WIP: ignore Aug 2, 2020
@camilamacedo86
Copy link
Member Author

I am closing this PR since we will change the solution.

@camilamacedo86 camilamacedo86 deleted the solve-test-env branch August 2, 2020 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droot droot Awaiting requested review from droot

@mengqiy mengqiy Awaiting requested review from mengqiy

@estroz estroz Awaiting requested review from estroz

Assignees

@DirectXMan12 DirectXMan12

@joelanford joelanford

@pwittrock pwittrock

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@camilamacedo86 @k8s-ci-robot @pwittrock @estroz @DirectXMan12 @joelanford