-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Update the Kubebuilder book tutorials for v3 #2302
📖 Update the Kubebuilder book tutorials for v3 #2302
Conversation
This is a WIP as I traverse the book. The initial docs (intro, quick start and arch) are reviewed. Next will be the cronjob tutorial. |
@camilamacedo86 First commit after running https://github.com/kubernetes-sigs/kubebuilder/blob/master/docs/book/src/cronjob-tutorial/testdata/generate_cronjob.sh. Let me kjnow if going in the right direction. |
a7260e1
to
220128c
Compare
Unit test failing. Just wondering if this is a glitch or not?
|
0d8aee2
to
1df7a31
Compare
Had to disable some unit tests because they are failing. I disabled https://github.com/kubernetes-sigs/kubebuilder/blob/master/docs/book/src/cronjob-tutorial/testdata/project/controllers/suite_test.go#L130-L145 because it is failing as follows:
I disabled https://github.com/kubernetes-sigs/kubebuilder/blob/master/docs/book/src/cronjob-tutorial/testdata/project/controllers/cronjob_controller_test.go#L186-L198 as it is failing as follows:
|
@camilamacedo86 I would appreciate your feedback when you get a chance. Note the tests disabled as described in #2302 (comment). |
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
1df7a31
to
fbc6a30
Compare
/retest |
HI @hickeyma, We need to solve : kubernetes-sigs/controller-runtime#1571 |
docs/book/src/multiversion-tutorial/testdata/project/config/default/kustomization.yaml
Outdated
Show resolved
Hide resolved
docs/book/src/cronjob-tutorial/testdata/project/controllers/suite_test.go
Outdated
Show resolved
Hide resolved
docs/book/src/cronjob-tutorial/testdata/project/controllers/cronjob_controller_test.go
Outdated
Show resolved
Hide resolved
Thanks for the feedback @camilamacedo86. Blocked waiting on #2325 |
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
4c852eb
to
0c4ffef
Compare
@camilamacedo86 I updated the failing tests and they are now passing. I have updated the controller-runtime |
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tutorial envtest bits will need to be changed when teardown starts working properly again. For now the comments are explanatory enough.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: estroz, hickeyma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for the reviews @camilamacedo86 @estroz, and for merging @estroz. |
Thanks for your contribution! |
This PR updates the Kubebuilder book tutorials to align with the current version, v3. This fix will help users navigate the book with success.
Fixes #2273