⚠️ (go/v3) upgrade controller-runtime from 0.10.0 to 0.11.0, k8s from 1.22 to 1.23 and controller-gen from v0.0.7 to v0.8.0

[ankitm123]

Description

• upgrade controller-runtime from 0.10.0 to 0.11.0
• k8s from 1.22 to 1.23
• controller-gen from v0.0.7 to v0.8.0

also, envtest setup from 1.22 to 1.23

NOTE: This pr changes the scaffolds produced by KB CLI for go/v3 plugin. The go/v2 plugin cannot be upgraded and has been kept as a legacy.

Signed-off-by: ankitm123 ankitmohapatra123@gmail.com

fixes #2448

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ ankitm123 (7ae4803)

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @ankitm123!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[ankitm123]

Seems like for make install and make generate to work, it needs go1.17.
In case of go1.16, I am seeing these errors:

# sigs.k8s.io/json/internal/golang/encoding/json
../../../pkg/mod/sigs.k8s.io/json@v0.0.0-20211020170558-c049b76a60c6/internal/golang/encoding/json/encode.go:1249:12: sf.IsExported undefined (type reflect.StructField has no field or method IsExported)
../../../pkg/mod/sigs.k8s.io/json@v0.0.0-20211020170558-c049b76a60c6/internal/golang/encoding/json/encode.go:1255:18: sf.IsExported undefined (type reflect.StructField has no field or method IsExported)

I can try to track down the errors, probably need to pin some packages, if upgrade to go1.17 is undesired.
I also see #2446 addresses the upgrade to go1.17, so I can wait for that PR to go in, and then rebase (as I can see in that PR, tests need to be updated to use go1.17 🤔 )?

Basically structfield.IsExported was added in go 1.17, and hence requires go 1.17.
Pinning the version of k8s.io/apimachinery to v0.22.2 makes it work with go < 1.17

EDIT: I went ahead and pinned the version of apimachinary to v0.22.2, and that seems to pass install and unit tests locally for me.

[k8s-ci-robot]

Hi @ankitm123. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[camilamacedo86]

Thank you for your contribution 🥇

Just a few nits:
a) To update the controller-runtime into the scaffolds is required to do the change in:
->

kubebuilder/pkg/plugins/golang/v3/scaffolds/init.go

Line 33 in ecce96f

ControllerRuntimeVersion = "v0.10.0"

• Then, run make generate to update all scaffolds.

b) Since the goal is the scaffolds began to use the new version we must use the mojo ':warning:' in the title. Also, since it is used to create our release notes WDYT about : :warning: (go/v3) upgrade controller-runtime from 0.10 to 0.11

Is it required to upgrade the go version as well? If yes, that we need to clarify that in the title, an update in the scaffolds as in the docs regards the go version required. E.g ( :warning: (go/v3) upgrade controller-runtime from 0.10 to 0.11, k8s to , and golang version to 1.17

[camilamacedo86]

/ok-to-test

[ankitm123]

Also, since it is used to create our release notes WDYT about : :warning: (go/v3) upgrade controller-runtime from 0.10 to 0.11

sgtm, will update.

[ankitm123]

@camilamacedo86 So I went forward and upgraded the go version in this PR along with the commit message. I will check why the PRs are failing, and update this PR.

[ankitm123]

This file needs to be updated with go:17: https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/kubebuilder/kubebuilder-presubmits.yaml

[varshaprasad96]

/hold

[camilamacedo86]

Shows that we are also missing updated: https://github.com/kubernetes-sigs/kubebuilder/blob/master/build/.goreleaser.yml#L46

[ankitm123]

All tests (except api-diff) passed finally! 🎉

[ankitm123]

/hold cancel

[camilamacedo86]

/lgtm

@varshaprasad96 wdyt can we move forward here?
See that the appdiff in this case does not seems be possible to comply with see: https://github.com/kubernetes-sigs/kubebuilder/runs/4770481855?check_suite_focus=true#step:5:49

[camilamacedo86]

/override APIDiff

[k8s-ci-robot]

@camilamacedo86: /override requires a failed status context or a job name to operate on.
The following unknown contexts were given:

• APIDiff

Only the following contexts were expected:

• cla/linuxfoundation
• netlify/kubebuilder/deploy-preview
• pull-kubebuilder-e2e-k8s-1-14-10
• pull-kubebuilder-e2e-k8s-1-15-12
• pull-kubebuilder-e2e-k8s-1-16-15
• pull-kubebuilder-e2e-k8s-1-17-11
• pull-kubebuilder-e2e-k8s-1-18-8
• pull-kubebuilder-e2e-k8s-1-19-4
• pull-kubebuilder-e2e-k8s-1-20-7
• pull-kubebuilder-e2e-k8s-1-21-2
• pull-kubebuilder-e2e-k8s-1-22-1
• pull-kubebuilder-test
• tide

In response to this:

/override APIDiff

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[camilamacedo86]

/override ci/APIDiff

[k8s-ci-robot]

@camilamacedo86: /override requires a failed status context or a job name to operate on.
The following unknown contexts were given:

• ci/APIDiff

Only the following contexts were expected:

• cla/linuxfoundation
• netlify/kubebuilder/deploy-preview
• pull-kubebuilder-e2e-k8s-1-14-10
• pull-kubebuilder-e2e-k8s-1-15-12
• pull-kubebuilder-e2e-k8s-1-16-15
• pull-kubebuilder-e2e-k8s-1-17-11
• pull-kubebuilder-e2e-k8s-1-18-8
• pull-kubebuilder-e2e-k8s-1-19-4
• pull-kubebuilder-e2e-k8s-1-20-7
• pull-kubebuilder-e2e-k8s-1-21-2
• pull-kubebuilder-e2e-k8s-1-22-1
• pull-kubebuilder-test
• tide

In response to this:

/override ci/APIDiff

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[camilamacedo86]

/skip APIDiff

[ankitm123]

It's a github check, and not prow, so override wont work 🤔 , needs to be done in gh(?).

[camilamacedo86]

Hi @ankitm123

It's a github check, and not prow, so override wont work 🤔 , needs to be done in gh.

Yep. I was trying to see if we let it merge alone. I can force the merge anyway.
Let's just wait for @varshaprasad96 oks as well. then I can do that.

[varshaprasad96]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitm123, camilamacedo86, varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment