-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ : Generate Dockerfile from declarative plugin #2507
✨ : Generate Dockerfile from declarative plugin #2507
Conversation
Hi @viveksyngh. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
09748dc
to
f9e8b88
Compare
f9e8b88
to
e5659b2
Compare
pkg/plugins/golang/declarative/v1/internal/templates/dockerfile.go
Outdated
Show resolved
Hide resolved
pkg/plugins/golang/declarative/v1/internal/templates/dockerfile.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution 🥇
A few questions were added could you please check?
Also, note that we need to run make generate
to generate the samples in the testata dir with the changes performed for each PR.
e5659b2
to
4b6a3a3
Compare
/ok-to-test |
b6fc1b6
to
671e1c2
Compare
We need to copy the channels directory in the Dockerfile, particularly now that we're running with non-root permissions and it is no longer a one-liner. Signed-off-by: Vivek Singh <svivekkumar@vmware.com>
671e1c2
to
af24fad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @viveksyngh that is great.
It shows for me that we have just a nit https://github.com/kubernetes-sigs/kubebuilder/pull/2507/files#r811398584. Otherwise it shows great for me.
Let's try to ping @justinsb as well.
I can see that the methods complained in the API diff are present in kubebuilder/pkg/plugins/golang/declarative/v1/api.go Lines 73 to 77 in af24fad
So /lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approved
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, viveksyngh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Forcing this one since it. shows an issue in the API check: #2507 (comment) |
We need to copy the channels directory in the Dockerfile, particularly
now that we're running with non-root permissions and it is no longer a
one-liner.
Signed-off-by: Vivek Singh svivekkumar@vmware.com