Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Update make build cmd with manifests generation #3020

Merged
merged 1 commit into from
Oct 22, 2022
Merged

✨ Update make build cmd with manifests generation #3020

merged 1 commit into from
Oct 22, 2022

Conversation

astraw99
Copy link
Contributor

@astraw99 astraw99 commented Oct 16, 2022 •
edited
Loading

Fixes #3016
In the doc of xxx_types.go, the comment said:

Important: Run "make" to regenerate code after modifying this file

But after the spec and status struct modified, run make did not generate manifests fields.

So this PR update make (default to make build) with manifests generation.
Plugins go/v3 and go/v4-alpha are updated.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 16, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @astraw99. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@astraw99 astraw99 changed the title ✨: Update make build cmd with manifests ✨ Update make build cmd with manifests Oct 16, 2022
@astraw99 astraw99 mentioned this pull request Oct 16, 2022
Closed
@astraw99 astraw99 changed the title ✨ Update make build cmd with manifests ✨ Update make build cmd with manifests generation Oct 16, 2022
@camilamacedo86
Copy link
Member

/ok-to-test
/approved

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 17, 2022
camilamacedo86
camilamacedo86 approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approved

Thank you 🥇

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2022
@astraw99
Copy link
Contributor Author

@camilamacedo86 Could you please add a /lgtm label to push it to merge, thanks.

@camilamacedo86
Copy link
Member

camilamacedo86 commented Oct 17, 2022 •
edited
Loading

Hi @astraw99,

@camilamacedo86 Could you please add a /lgtm label to push it to merge, thanks.

It would be nice to get done for another maintainer. So, let's waiting for someone to have time to do a second review here.

camilamacedo86
camilamacedo86 approved these changes Oct 22, 2022
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ihmo we can move forward here since it is a small change
So,

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astraw99, camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5d59e40 into kubernetes-sigs:master Oct 22, 2022
@camilamacedo86 camilamacedo86 mentioned this pull request Oct 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@joelanford joelanford Awaiting requested review from joelanford

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Got errors on kubebuilder v3 quick start
3 participants
@astraw99 @k8s-ci-robot @camilamacedo86