-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ deprecate declarative plugin #3395
⚠️ deprecate declarative plugin #3395
Conversation
Skipping CI for Draft Pull Request. |
b6065b1
to
07da44f
Compare
@camilamacedo86 I'm fine moving ahead with the PR. Just want to confirm if Kubebuilder declarative pattern maintainers are comfortable with us doing this, or would like to first externalize the plugin and then deprecate (followed by remove) it. cc: @justinsb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
Nits:
What about also removing:
kubebuilder/docs/book/src/SUMMARY.md
Line 122 in 7711b8f
- [declarative/v1](./plugins/declarative-v1.md) declarative.go.kubebuilder.io/v1: [kubebuilder-declarative-pattern]: https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern &declarativev1.Plugin{}, kubebuilder/pkg/cli/cli_test.go
Line 172 in 7711b8f
pluginChain := []string{"go.kubebuilder.io/v2", "declarative.kubebuilder.io/v1"}
07da44f
to
2ecfba3
Compare
2ecfba3
to
07d8627
Compare
07d8627
to
b628e7e
Compare
b628e7e
to
064d59c
Compare
064d59c
to
a625b74
Compare
a625b74
to
6b48f49
Compare
6b48f49
to
70d3f3c
Compare
/retest |
70d3f3c
to
5f1708d
Compare
5f1708d
to
f4ffb98
Compare
/test pull-kubebuilder-e2e-k8s-1-25-3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍🏼
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, everettraven, Kavinjsir The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description:
This PR deprecates the declarative plugin and adds the following notice:
Also, we are:
Closes: #3186
Related to : kubernetes-sigs/kubebuilder-declarative-pattern#293