🌱 ci: fix GitHub action to test make test-e2e for deploy-image #4118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/S
camilamacedo86
force-pushed
the
fix-e2e-deploy-image
branch
2 times, most recently
from
6a7ea5a
to
d1a0cb8
Compare
k8s-ci-robot
added
size/M
camilamacedo86
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
camilamacedo86
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
camilamacedo86
force-pushed
the
fix-e2e-deploy-image
branch
from
f5375f9
to
3d05c86
Compare
k8s-ci-robot
added
size/XL
camilamacedo86
force-pushed
the
fix-e2e-deploy-image
branch
from
d4cc789
to
8d4ea33
Compare
k8s-ci-robot
added
size/L
camilamacedo86
force-pushed
the
fix-e2e-deploy-image
branch
2 times, most recently
from
7adb1e4
to
f63a05d
Compare
k8s-ci-robot
added
size/M
k8s-ci-robot
added
the
size/L
camilamacedo86
force-pushed
the
fix-e2e-deploy-image
branch
from
e299edc
to
58f086f
Compare
k8s-ci-robot
added
size/XL
camilamacedo86
force-pushed
the
fix-e2e-deploy-image
branch
2 times, most recently
from
57f6f01
to
d177c64
Compare
k8s-ci-robot
added
size/M
camilamacedo86
force-pushed
the
fix-e2e-deploy-image
branch
from
d177c64
to
7480892
Compare
k8s-ci-robot
added
size/S
camilamacedo86
force-pushed
the
fix-e2e-deploy-image
branch
from
fd5ea33
to
8b63f4e
Compare
camilamacedo86
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
For the DeployImage sample, we are only using validating webhooks. This commit updates the scaffold to reflect this by customizing the configuration accordingly. Additionally, there is a known bug in the tool where it scaffolds uncommented data for MutatingWebhooks. As a workaround, this commit comments out the unnecessary MutatingWebhook configurations to avoid issues during the test execution.
camilamacedo86
force-pushed
the
fix-e2e-deploy-image
branch
from
8b63f4e
to
9de4d9a
Compare
|
I am moving forward because it is a nit/fix Also, anyone can propose further changes in follow ups |
camilamacedo86
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the DeployImage sample, we are only using validating webhooks.
This commit updates the scaffold to reflect this by customizing
the configuration accordingly.
Additionally, there is a known bug in the tool where it scaffolds
uncommented data for MutatingWebhooks. As a workaround, this commit
comments out the unnecessary MutatingWebhook configurations to avoid
issues during the test execution.