Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 (go/v4): fix indentation of imports in test files #4623

Merged
merged 1 commit into from
Mar 21, 2025
Merged

🐛 (go/v4): fix indentation of imports in test files #4623

merged 1 commit into from
Mar 21, 2025

Conversation

kersten
Copy link
Contributor

@kersten kersten commented Mar 20, 2025

Correct indentation for imported packages in the e2e test suite to maintain consistent code formatting.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 20, 2025
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 20, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @kersten. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

camilamacedo86
camilamacedo86 reviewed Mar 20, 2025
View reviewed changes
pkg/plugins/golang/v4/scaffolds/internal/templates/test/e2e/suite.go
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to run make generate so that the change made in the template/bollerplate will be reflect in all samples and docs.

Also, since it will endup in a change available for end users we cannot use the 🌱 in this case we can use for example : 🐛 and we should add the plugin impacted by. I hope that you do not mind I will update the title, because we use it for our release notes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran make generate and re run it again, there are no such changes in the samples and docs 🧐, also all my workflows are succeeding. Did I miss something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But wait, just found some other places. I will recheck

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the other places and ran 'make generate' again

@camilamacedo86 camilamacedo86 changed the title 🌱 style: fix indentation in e2e test suite 🐛 (go/v4): fix indentation of imports in e2e test suite Mar 20, 2025
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 20, 2025
@kersten kersten changed the title 🐛 (go/v4): fix indentation of imports in e2e test suite 🐛 (go/v4): fix indentation of imports in test files Mar 20, 2025
camilamacedo86
camilamacedo86 reviewed Mar 20, 2025
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kersten,

Just a small request—could you please squash the commits?

We follow a policy of one PR → one commit → one need/bug/enhancement to maintain a clean and structured Git history. This makes it easier to revert changes if necessary and helps avoid potential conflicts.

Thanks! 🚀

@kersten
style: fix indentation in tests
31e29b6 
correct indentation for imports in test files

This commit addresses the inconsistent indentation in several
test files. The imports are now properly aligned using tabs instead of
spaces to maintain consistency across the codebase. This change does
not affect functionality but improves code readability.
@kersten kersten force-pushed the style/fix-indentation-in-e2e-test-suite branch from 742aac4 to 31e29b6 Compare March 20, 2025 10:11
@kersten
Copy link
Contributor Author

kersten commented Mar 20, 2025

Hi @kersten,

Just a small request—could you please squash the commits?

We follow a policy of one PR → one commit → one need/bug/enhancement to maintain a clean and structured Git history. This makes it easier to revert changes if necessary and helps avoid potential conflicts.

Thanks! 🚀

Sure, I missed the --amend flag - wasn't intentional.

camilamacedo86
camilamacedo86 approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 21, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, kersten

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2025
@k8s-ci-robot k8s-ci-robot merged commit f28fa7b into kubernetes-sigs:master Mar 21, 2025
27 checks passed
@kersten kersten deleted the style/fix-indentation-in-e2e-test-suite branch April 1, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@Kavinjsir Kavinjsir Awaiting requested review from Kavinjsir

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kersten @k8s-ci-robot @camilamacedo86