Skip to content

Conversation

@camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Jul 11, 2025

  • Move the tests that do not require running on the cluster to run in the job pull-kubebuilder-test just once
  • Change TestContext to work well outside of the cluster (it tries to capture the Kubernetes version so we have it tracked in case we want to skip a test for a specific version)
  • Update e2e tests to move grafana and alphagenerate to run on this job, since they do not require a cluster
  • Improve e2e tests for alpha generate by reducing the number of mocks — we don’t need one mock per plugin; we can use a single mock with all plugins scaffolded to validate properly. This should significantly reduce the time needed to perform the tests

We can check that the tests were executed here: https://storage.googleapis.com/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_kubebuilder/4921/pull-kubebuilder-test/1943729959755321344/build-log.txt

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 11, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 11, 2025
@camilamacedo86 camilamacedo86 force-pushed the add-make-tests-faster branch from dfce1a4 to 4aa8c2e Compare July 11, 2025 17:51
@vitorfloriano
Copy link
Contributor

LGTM

@camilamacedo86 camilamacedo86 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2025
@k8s-ci-robot k8s-ci-robot merged commit 1948c3e into kubernetes-sigs:master Jul 11, 2025
23 checks passed
@camilamacedo86 camilamacedo86 deleted the add-make-tests-faster branch July 11, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants