-
Notifications
You must be signed in to change notification settings - Fork 1.6k
🐛 Fix link shared about plugin versioning when plugins are not found #5021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
update unreachable url
The committers listed above are authorized under a signed CLA. |
|
Welcome @ricardo1u! |
|
Hi @ricardo1u. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
camilamacedo86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 🥇
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, ricardo1u The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
|
/hold cancel |
|
/ok-to-test |
|
/approved |
|
|
||
| const unstablePluginMsg = " (plugin version is unstable, there may be an upgrade available: " + | ||
| "https://kubebuilder.io/migration/plugin/plugins.html)" | ||
| "https://kubebuilder.io/plugins/plugins-versioning)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What plugin are you using that you faced this message?
Could you please share? What plugin info is in your PROJECT file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any project, i was reading, learning and testing resource code , and I notice this wrong .And i'm very glad that i can make some contribution to community, even it is just a little.
the url denote to kubebuilder's tutorial is outdated