Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

correct steps in ingress and service with coredns document #1229

Merged
merged 1 commit into from
May 14, 2020

Conversation

xunpan
Copy link
Contributor

@xunpan xunpan commented May 13, 2020

There are 4 issues updated in the document

  1. switch from minikube to kind
  2. add RBAC for clusterrole external-dns
  3. add labels to make kubefed controller works
  4. update link to metallb

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1217

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 13, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xunpan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 13, 2020
@xunpan
Copy link
Contributor Author

xunpan commented May 13, 2020

/retest

@hectorj2f
Copy link
Contributor

@xunpan isn't it possible to use minikube anymore ? should we exclude it as a list of supported environment ?

@xunpan
Copy link
Contributor Author

xunpan commented May 14, 2020

@hectorj2f
For this document, I update it to kind because minikube is not our defaullt simulated multiple clusters environment anymore. A case on kind can be easily move to minikube on demand.

To me, I think we do not need to maintain minikube because currently kind works fine. I do not see any value to have multiple simulated environment maintained.

@hectorj2f
Copy link
Contributor

@xunpan Perhaps we should ask if we want to maintain examples for minikube in the community channel.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit 96f89dc into kubernetes-retired:master May 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

empty spec in dnsendpoint
3 participants