This repository was archived by the owner on Apr 25, 2023. It is now read-only.
retain healthCheckNodePort for service when updating #1347
Merged
+97
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bruce Ma <brucema19901024@gmail.com>
k8s-ci-robot
added
the
cncf-cla: yes
|
CI is failing with
|
|
I just restarted the build. Let's hope for the best. |
|
@mars1024 Could you add one unit test for this change ? |
Signed-off-by: Bruce Ma <brucema19901024@gmail.com>
k8s-ci-robot
added
size/M
Of course! I added some unit tests for this. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hectorj2f, mars1024 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bruce Ma brucema19901024@gmail.com
What this PR does / why we need it:
For services which type==LoadBalancer and externalTrafficPolicy==Local, their field
spec.healthCheckNodePortwill be allocated by APIServer, and after that it should be unchangeable, so we should retain this field during update, just likespec.clusterIPandnodePortin ports.Here we don't need to check whether the desired service need
healthCheckNodePortbut just pass it on, because if the passedhealthCheckNodePortis not needed any more, it will be recycled by APIServer.Special notes for your reviewer:
Codes in kubernetes about the validation on
spec.healthCheckNodePort, https://github.com/kubernetes/kubernetes/blob/68108c70e29a74bb455ab63adeb5725a37e94e4f/pkg/registry/core/service/storage/rest.go#L369