Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not updated sample in inventory for change {kube,system}_master_{cpu,memory,ephemeral-storage,pid} #11876

Open
pbromb opened this issue Jan 10, 2025 · 4 comments · May be fixed by #11895 or #11897
Open
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@pbromb
Copy link

pbromb commented Jan 10, 2025

What happened?

File in inventory /sample/group_vars/k8s_cluster/k8s-cluster.yml contains an outdated configuration example for control planes, where the {kube,system}_master_{cpu,memory,ephemeral-storage,pid} values were removed in v2.27.0. In the sample inventory there is no kube_control_plane.yml file with the configuration

What did you expect to happen?

I expect the sample configuration to be up to date

How can we reproduce it (as minimally and precisely as possible)?

n/a

OS

Linux 6.1.0-21-amd64 x86_64
PRETTY_NAME="Debian GNU/Linux 12 (bookworm)"
NAME="Debian GNU/Linux"
VERSION_ID="12"
VERSION="12 (bookworm)"
VERSION_CODENAME=bookworm
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"

Version of Ansible

ansible [core 2.16.7] (detached HEAD 4a0839bf60) last updated 2024/06/10 19:51:29 (GMT +200)
config file = /etc/ansible/ansible.cfg
configured module search path = ['/root/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
ansible python module location = /opt/ansible-2.16.7/lib/ansible
ansible collection location = /etc/ansible/collections
executable location = /opt/ansible-2.16.7/bin/ansible
python version = 3.11.2 (main, Mar 13 2023, 12:18:29) [GCC 12.2.0] (/usr/bin/python)
jinja version = 3.1.2
libyaml = True

Version of Python

Python 3.11.2

Version of Kubespray (commit)

v2.27.0

Network plugin used

cilium

Full inventory with variables

n/a

Command used to invoke ansible

n/a

Output of ansible run

n/a

Anything else we need to know

No response

@pbromb pbromb added the kind/bug Categorizes issue or PR as related to a bug. label Jan 10, 2025
@tico88612
Copy link
Member

/remove-kind bug
/kind documentation
/triage accepted

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed kind/bug Categorizes issue or PR as related to a bug. labels Jan 14, 2025
@tico88612
Copy link
Member

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@tico88612:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jan 14, 2025
@anshuman-agarwala
Copy link

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
4 participants