-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add venv and caching to accelerate CIs #10116
Conversation
This introduces the problem when dependencies are upgraded we need to fix the cache.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: j4m3s-s The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @j4m3s-s. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I don't mind either, although I usually prefer using python dependencies from pip rather than system ones, especially since it's probably how people use it (at least that's how I would expect them to). I can close it if you still think this is not worth pursuing though. |
I think it could be worth it to add some venv directly in the dockerfile and if we still wants to support two versions of Ansible we could have two venv there for instance. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR adds a cache for pip dependencies to speed up the CIs.
This introduces the problem when dependencies are upgraded we need to fix the cache.
What type of PR is this?
What this PR does / why we need it:
CI have been failing quite a bit recently (for various reasons that I'm not entirely aware of). Speeding them up would probably free up a lot of CI time and make it easier to land PR upstream.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: