Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump flannel version to v0.22.0 and flannel-cni-plugin version to v1.1.2 #10205

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

eminaktas
Copy link
Contributor

@eminaktas eminaktas commented Jun 8, 2023

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

/kind feature

What this PR does / why we need it:

Upgrades flannel and flannel-cni-plugin versions

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

bump flannel version to v0.22.0 and flannel-cni-plugin version to v1.1.2. Also, changes flannel repository from flannelcni to flannel

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 8, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @eminaktas. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 8, 2023
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you contribution! Looks goods, but IIRC we repush flannel images in a kubespray specific registry so CI might fail while it's not done 🙈.
/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 8, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2023
@eminaktas
Copy link
Contributor Author

@MrFreezeex I just noticed that the https://github.com/flannel-io/cni-plugin repository does not have v1.2.0. However, they pointed out that the latest tag is now v1.1.2. You can see the comment here.

This also changes flannel repository from flannelcni to flannel

Signed-off-by: Emin Aktaş <eminaktas34@gmail.com>
@eminaktas eminaktas changed the title bump flannel version to 0.22.0 bump flannel version to v0.22.0 and flannel-cni-plugin version to v1.1.2 Jun 8, 2023
@oomichi
Copy link
Contributor

oomichi commented Jun 13, 2023

packet_coreos7-flannel-addons-ha job was failed with

fatal: [instance-3 -> instance-1(172.30.76.110)]: FAILED! => 
 {"attempts": 4, "changed": true, "cmd": ["/usr/local/bin/nerdctl", "-n", "k8s.io", "pull", "--quiet", "quay.io/kubespray/flannel:v0.22.0"],
 [..]
 level=fatal msg=\"failed to resolve reference \\\"quay.io/kubespray/flannel:v0.22.0\\\": quay.io/kubespray/flannel:v0.22.0: not found

@eminaktas
Copy link
Contributor Author

packet_coreos7-flannel-addons-ha job was failed with

fatal: [instance-3 -> instance-1(172.30.76.110)]: FAILED! => 
 {"attempts": 4, "changed": true, "cmd": ["/usr/local/bin/nerdctl", "-n", "k8s.io", "pull", "--quiet", "quay.io/kubespray/flannel:v0.22.0"],
 [..]
 level=fatal msg=\"failed to resolve reference \\\"quay.io/kubespray/flannel:v0.22.0\\\": quay.io/kubespray/flannel:v0.22.0: not found

quay.io/kubespray/flannel

@MrFreezeex mentioned that above. How can we fix it?

https://hub.docker.com/r/flannel/flannel images are here.

crane ls quay.io/kubespray/flannel
v0.17.0
v0.17.0-amd64
v0.18.1-amd64
v0.18.1
v0.19.2-amd64
v0.20.1
v0.20.2
v0.21.4

@MrFreezeex
Copy link
Member

Correct me if I'm wrong but I think @floryut did the last push to our flannel mirror 😅 👀

@floryut
Copy link
Member

floryut commented Jun 19, 2023

Correct me if I'm wrong but I think @floryut did the last push to our flannel mirror 😅 👀

indeed, on it
done

@MrFreezeex
Copy link
Member

🎉
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2023
@oomichi
Copy link
Contributor

oomichi commented Jun 19, 2023

Thanks for fixing the issue.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eminaktas, MrFreezeex, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7a66be8 into kubernetes-sigs:master Jun 19, 2023
@MrFreezeex MrFreezeex mentioned this pull request Jun 22, 2023
maciej-markowski pushed a commit to maciej-markowski/kubespray that referenced this pull request Jun 23, 2023
…1.2 (kubernetes-sigs#10205)

This also changes flannel repository from flannelcni to flannel

Signed-off-by: Emin Aktaş <eminaktas34@gmail.com>
@yankay yankay mentioned this pull request Aug 24, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
…1.2 (kubernetes-sigs#10205)

This also changes flannel repository from flannelcni to flannel

Signed-off-by: Emin Aktaş <eminaktas34@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants