-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to set SSL_CERT_FILE for offline installation using custom CA for https proxy #10215
Conversation
Welcome @HappyFX! |
Hi @HappyFX. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
Is it ok to add more verbosity in molecule tests with |
@oomichi changed with suggestion |
Have no idea why CI is failed on artefact push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HappyFX Thank you for the PR, great desc/doc 🙇
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, HappyFX The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
All tests are passed. Can we merge or need some additional actions? |
Thanks @HappyFX Nice PR! Should the |
@yankay ready |
Thanks @HappyFX /lgtm |
/easycla |
|
@HappyFX Can you check that your commit email address match the one on your GitHub profile (by changing it in the commit or adding it in GitHub probably)? |
changed commit email to github user and email |
Thanks! |
What type of PR is this?
What this PR does / why we need it:
Add option to pass in environment
SSL_CERT_FILE
to use custom CAhttps_proxy
Which issue(s) this PR fixes:
Fixes #10214
Special notes for your reviewer:
Does this PR introduce a user-facing change?: