Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[etcd] make etcd 3.5.16 default #11572

Merged
merged 2 commits into from
Sep 26, 2024
Merged

[etcd] make etcd 3.5.16 default #11572

merged 2 commits into from
Sep 26, 2024

Conversation

janosbabik
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Related issue: #11555

Does this PR introduce a user-facing change?:

[etcd] Default version to 3.5.16 for 1.28, 1.29, 1.30, 1.31

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Sep 25, 2024
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Sep 25, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 25, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @janosbabik!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 25, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @janosbabik. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 25, 2024
@VannTen
Copy link
Contributor

VannTen commented Sep 25, 2024 via email

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 25, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: janosbabik, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2024
@VannTen
Copy link
Contributor

VannTen commented Sep 25, 2024

Hum, yeah, without the checksums this isn't going to work ^^

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2024
@VannTen
Copy link
Contributor

VannTen commented Sep 26, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit 656ed79 into kubernetes-sigs:master Sep 26, 2024
40 checks passed
@janosbabik
Copy link
Contributor Author

Hi @VannTen, what is the way to cherry pick this to 2.25 and 2.26?

@VannTen
Copy link
Contributor

VannTen commented Sep 26, 2024 via email

@k8s-infra-cherrypick-robot
Copy link

@VannTen: #11572 failed to apply on top of branch "release-2.26":

Applying: make etcd 3.5.16 default
Using index info to reconstruct a base tree...
M	README.md
M	roles/kubespray-defaults/defaults/main/download.yml
Falling back to patching base and 3-way merge...
Auto-merging roles/kubespray-defaults/defaults/main/download.yml
CONFLICT (content): Merge conflict in roles/kubespray-defaults/defaults/main/download.yml
Auto-merging README.md
CONFLICT (content): Merge conflict in README.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 make etcd 3.5.16 default
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

A direct cherry-pick probably won't work, so you probably need to do it manually by relauching the script manually on those branches

Let's try it anyway:

/cherrypick release-2.26
/cherrypick release-2.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@VannTen
Copy link
Contributor

VannTen commented Sep 26, 2024 via email

JosBritton added a commit to JosBritton/kubespray that referenced this pull request Sep 26, 2024
@JosBritton
Update inventory using latest sample reference
f52908e 
commit 656ed79
Author: janosbabik <143906591+janosbabik@users.noreply.github.com>
Date:   Thu Sep 26 10:12:01 2024 +0200

    [etcd] make etcd 3.5.16 default (kubernetes-sigs#11572)

    * [etcd] make etcd 3.5.16 default

    * Update etcd binary checksums for version 3.5.16 and lower

commit e355bef
Author: Bakke <luringens@protonmail.com>
Date:   Thu Sep 26 07:22:02 2024 +0000

    fix: vsphere image repositories, tags and docs (kubernetes-sigs#11564)

    The old repository for these has been deleted, leaving the previous
    configuration not possible to deploy, and even currently running clusters
    fail after a restart as the DeameonSet has ImagePullPolicy: Always. More
    details can be found here: kubernetes-sigs/vsphere-csi-driver#3053

    As of writing, only CSI driver versions 3.1.2 to 3.3.1 is available in
    this registry. This "officially" supports Kubernetes 1.26 to 1.30. Since
    older drivers are not available, I have removed some feature-gating for
    those unavailable versions while I was at it. For the cloud provider,
    the `latest` image is now missing, and only 1.28.0 to 1.31.0 are
    available. I've set the latest of these as the new default.

    I also updated the documented default versions, as they were all out of
    date and not aligned with actual code defaults.

commit 15bb5b0
Author: Philip Sabri <Philipsabri@gmail.com>
Date:   Wed Sep 25 06:10:01 2024 +0200

    [kubernetes] Support kubernetes 1.31.1 (kubernetes-sigs#11533)

commit ebdc599
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Sep 24 02:52:00 2024 +0100

    Bump tox from 4.18.1 to 4.20.0 (kubernetes-sigs#11562)

    Bumps [tox](https://github.com/tox-dev/tox) from 4.18.1 to 4.20.0.
    - [Release notes](https://github.com/tox-dev/tox/releases)
    - [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst)
    - [Commits](tox-dev/tox@4.18.1...4.20.0)

    ---
    updated-dependencies:
    - dependency-name: tox
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 1c0718b
Author: Baargav <baargavrag@gmail.com>
Date:   Mon Sep 23 10:31:59 2024 -0400

    update containerd 1.7.22 (kubernetes-sigs#11554)

commit 03a055c
Merge: e9d406e fe60832
Author: Kubernetes Prow Robot <20407524+k8s-ci-robot@users.noreply.github.com>
Date:   Mon Sep 23 14:16:00 2024 +0100

    Merge pull request kubernetes-sigs#10643 from VannTen/cleanup/k8s_node_templates

    Refactor kubernetes/node templates

commit e9d406e
Merge: 99c6a88 1818993
Author: Kubernetes Prow Robot <20407524+k8s-ci-robot@users.noreply.github.com>
Date:   Mon Sep 23 10:08:00 2024 +0100

    Merge pull request kubernetes-sigs#11559 from VannTen/cleanup/less_inventory_boilerplate

    Only require minimum structure in inventory, compute the rest

commit 99c6a88
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Sep 23 09:32:00 2024 +0100

    Bump ansible-lint from 24.9.0 to 24.9.2 (kubernetes-sigs#11563)

    Bumps [ansible-lint](https://github.com/ansible/ansible-lint) from 24.9.0 to 24.9.2.
    - [Release notes](https://github.com/ansible/ansible-lint/releases)
    - [Commits](ansible/ansible-lint@v24.9.0...v24.9.2)

    ---
    updated-dependencies:
    - dependency-name: ansible-lint
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 1818993
Author: Max Gautier <mg@max.gautier.name>
Date:   Sat Sep 21 15:10:59 2024 +0200

    CI: for upgrade testing, checkout old version before provisioning

    Otherwise, modifying the test inventory + it's expected structure will
    always fail.

commit 88b6f08
Author: Max Gautier <mg@max.gautier.name>
Date:   Sat Sep 21 14:33:45 2024 +0200

    Documentation of k8s_cluster auto-defined

    Also remove the group from the example inventory, since it should not be
    needed anymore.

commit 7580e59
Author: Max Gautier <mg@max.gautier.name>
Date:   Sat Sep 21 14:16:17 2024 +0200

    Define k8s_cluster dynamically

    This allows inventories to not define the k8s_cluster group manually.

commit 2ec1c93
Author: Max Gautier <mg@max.gautier.name>
Date:   Sat Sep 21 14:09:09 2024 +0200

    Test group membership with group_names

    Testing for group membership with group names makes Kubespray more
    tolerant towards the structure of the inventory.
    Where 'inventory_hostname in groups["some_group"] would fail if
    "some_group" is not defined, '"some_group" in group_names' would not.

commit 89ff071
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Fri Sep 20 10:45:58 2024 +0100

    Bump ansible-lint from 24.7.0 to 24.9.0 (kubernetes-sigs#11541)

    Bumps [ansible-lint](https://github.com/ansible/ansible-lint) from 24.7.0 to 24.9.0.
    - [Release notes](https://github.com/ansible/ansible-lint/releases)
    - [Commits](ansible/ansible-lint@v24.7.0...v24.9.0)

    ---
    updated-dependencies:
    - dependency-name: ansible-lint
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 1fa4bb7
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Fri Sep 20 09:33:39 2024 +0100

    Bump ansible from 9.8.0 to 9.10.0 (kubernetes-sigs#11540)

    Bumps [ansible](https://github.com/ansible-community/ansible-build-data) from 9.8.0 to 9.10.0.
    - [Changelog](https://github.com/ansible-community/ansible-build-data/blob/main/docs/release-process.md)
    - [Commits](ansible-community/ansible-build-data@9.8.0...9.10.0)

    ---
    updated-dependencies:
    - dependency-name: ansible
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 93ee122
Merge: 4323e5d d54356e
Author: Kubernetes Prow Robot <20407524+k8s-ci-robot@users.noreply.github.com>
Date:   Fri Sep 20 01:05:14 2024 +0100

    Merge pull request kubernetes-sigs#11521 from VannTen/cleanup/deduplicate_kubeadm_control_plane

    Use in inventory variables rather than patch files for kubeadm_patches

commit 4323e5d
Author: Leeon Fu <48649837+leeonfu@users.noreply.github.com>
Date:   Fri Sep 20 02:14:37 2024 +0800

    Reset operation, disable service enabled and clean container's logs. (kubernetes-sigs#11501)

commit 1636979
Merge: 893e9cb 4bf2d7a
Author: Kubernetes Prow Robot <20407524+k8s-ci-robot@users.noreply.github.com>
Date:   Thu Sep 19 13:46:45 2024 +0100

    Merge pull request kubernetes-sigs#11527 from VannTen/feat/vagrant_multi_inv

    Cleanup Vagrantfile and allow to use multiples inventories

commit 893e9cb
Merge: 76c42b4 5b057c7
Author: Kubernetes Prow Robot <20407524+k8s-ci-robot@users.noreply.github.com>
Date:   Wed Sep 18 13:18:44 2024 +0100

    Merge pull request kubernetes-sigs#11471 from VannTen/feat/config_plugin_list

    Update the list of admission plugins which needs config

commit 76c42b4
Author: Max Gautier <mg@max.gautier.name>
Date:   Wed Sep 18 14:04:50 2024 +0200

    CI: cleanup '-scale' tests infra (kubernetes-sigs#11535)

    There is actually no test using this since ad6fece,
    so there is no reason to keep that infra in our tests scripts.

commit b3b0077
Author: Max Gautier <mg@max.gautier.name>
Date:   Wed Sep 18 14:04:44 2024 +0200

    Remove unused test infrastructure (kubernetes-sigs#11529)

    These two files haven't been touched since 2016 and don't appear to be
    referenced anywhere else

commit e550118
Author: Qasim Mehmood <18313886+ThisIsQasim@users.noreply.github.com>
Date:   Wed Sep 18 15:54:44 2024 +0500

    Allow setting annotations on ingress-nginx service (kubernetes-sigs#11544)

commit c3de25c
Author: Max Gautier <mg@max.gautier.name>
Date:   Wed Sep 18 02:34:45 2024 +0200

    Move the CRI endpoint setting to kubelet config (kubernetes-sigs#11550)

    The `--container-runtime-endpoint` kubelet argument is deprecated in
    favor of the config file alternative.

commit 59dd713
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Sep 16 08:31:14 2024 +0100

    Bump molecule from 24.8.0 to 24.9.0 (kubernetes-sigs#11542)

    Bumps [molecule](https://github.com/ansible-community/molecule) from 24.8.0 to 24.9.0.
    - [Release notes](https://github.com/ansible-community/molecule/releases)
    - [Commits](ansible/molecule@v24.8.0...v24.9.0)

    ---
    updated-dependencies:
    - dependency-name: molecule
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit e5d2452
Author: Kay Yan <kay.yan@daocloud.io>
Date:   Sun Sep 15 20:59:13 2024 +0800

    fix elastx cleanup security groups (kubernetes-sigs#11411)

commit 8cb081a
Author: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
Date:   Sun Sep 15 00:35:13 2024 +0800

    Fix: download hash crictl link (kubernetes-sigs#11534)

    Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>

commit 4bf2d7a
Author: Max Gautier <mg@max.gautier.name>
Date:   Thu Sep 12 16:44:30 2024 +0200

    Rework vagrant documentation

    - Use proper syntax highlighting for config.rb examples
    - Consistent shell style ($ as prompt)
    - Use only one way to do things
    - Remove OS specific details

commit 1e769b7
Author: Max Gautier <mg@max.gautier.name>
Date:   Thu Sep 12 13:56:12 2024 +0200

    Rework vagrant inventory handling + support for multiples inventories

    The current way to handle a custom inventory in vagrant is a bit
    hackish, copy files around and can break Vagrantfile parsing in
    cornercase scenarios (removing vagrant inventories, or the inventory
    copied into vagrant inventory).

    Instead, simply pass additional inventories to the ansible-playbook
    command lines as raw arguments with `-i`.
    This also makes supporting multiples inventories trivial, so we add a
    new `$inventories` variable for that purpose.

commit 8d8d063
Author: Max Gautier <mg@max.gautier.name>
Date:   Fri Sep 13 03:31:12 2024 +0000

    Remove useless file (kubernetes-sigs#11526)

    This was somehow copied from vagrant docs, not sure why it's there...

commit c601c8f
Author: Kevin Huang <git@kevin.huang.to>
Date:   Thu Sep 12 23:21:12 2024 +0200

    fix: Swap kubespray-defaults & boostrap-os (kubernetes-sigs#11441)

    - Execute boostrap-os before so that Python is installed for kubespray-defaults
    - Remove outdated kubespray-defaults dependency on boostrap-os

commit 5ae433b
Author: Max Gautier <mg@max.gautier.name>
Date:   Thu Sep 12 10:01:13 2024 +0000

    Remove refs to rhel7 in Vagrantfile (kubernetes-sigs#11525)

commit d54356e
Author: Max Gautier <mg@max.gautier.name>
Date:   Tue Sep 10 17:38:56 2024 +0200

    Add testcase for kubeadm_patches

commit c87097f
Author: Max Gautier <mg@max.gautier.name>
Date:   Tue Sep 10 17:34:04 2024 +0200

    Document how to use kubeadm patches

commit 4e6ae04
Merge: d54cfba 230cb37
Author: Kubernetes Prow Robot <20407524+k8s-ci-robot@users.noreply.github.com>
Date:   Thu Sep 12 06:51:12 2024 +0100

    Merge pull request kubernetes-sigs#11513 from VannTen/feat/python_download

    Refactor and expand download_hash.py

commit 8e254ec
Author: Max Gautier <mg@max.gautier.name>
Date:   Tue Sep 10 12:00:26 2024 +0200

    kubeadm: allow to provide patch inline in inventories

    Specifying one directory for kubeadm patches is not ideal:
    1. It does not allow working with multiples inventories easily
    2. No ansible templating of the patch
    3. Ansible path searching can sometimes be confusing

    Instead, provide the patch directly in a variable, and add some quality
    of life to handle components targeting and patch ordering more
    explicitly (`target` and `type` which are translated to the kubeadm
    scheme which is based on the file name)

commit a8b66fd
Author: Max Gautier <mg@max.gautier.name>
Date:   Tue Sep 10 13:43:02 2024 +0200

    Deduplicate kubeadm_patches tasks

    kubernetes/control-plane and kubernetes/kubeadm roles both push kubeadm
    patches in the same way.
    Extract that code and make it a dependency of both.
    This is safe because it's only configuration for kubeadm, which only
    takes effect when kubeadm is run.

commit 230cb37
Author: Max Gautier <mg@max.gautier.name>
Date:   Sun Sep 8 11:12:24 2024 +0200

    download_hash: document usage

commit dec4e71
Author: Max Gautier <mg@max.gautier.name>
Date:   Fri Sep 6 16:21:20 2024 +0200

    download_hash: cache request for 'multi-hash' files

    This avoid re-downloading the same file for different arch and
    re-parsing it

commit 1b1045c
Author: Max Gautier <mg@max.gautier.name>
Date:   Fri Sep 6 15:25:53 2024 +0200

    download_hash: use persistent session

    This allows to reuse http connection and be more efficient.
    From rough measuring it saves around 25-30% of execution time.

commit 86855be
Author: Max Gautier <mg@max.gautier.name>
Date:   Fri Sep 6 10:56:03 2024 +0200

    download_hash: document missing support

commit b2e64ae
Author: Max Gautier <mg@max.gautier.name>
Date:   Thu Sep 5 17:15:12 2024 +0200

    download_hash: support 'multi-hash' components

commit a2644c7
Author: Max Gautier <mg@max.gautier.name>
Date:   Thu Sep 5 16:19:09 2024 +0200

    download_hash: add support for 'simple hash' components

commit e256f74
Author: Max Gautier <mg@max.gautier.name>
Date:   Thu Sep 5 16:39:04 2024 +0200

    download_hash: propagate new patch versions to all archs

commit 2710e98
Author: Max Gautier <mg@max.gautier.name>
Date:   Thu Sep 5 15:58:36 2024 +0200

    download_hash: argument handling with argparse

    Allow the script to be called with a list of components, to only
    download new versions checksums for those.
    By default, we get new versions checksums for all supported (by the
    script) components.

commit da0e445
Author: Max Gautier <mg@max.gautier.name>
Date:   Fri Feb 2 20:48:08 2024 +0100

    download_hash.py: support for 'multi-hash' file + runc

    runc upstream does not provide one hash file per assets in their
    releases, but one file with all the hashes.
    To handle this (and/or any arbitrary format from upstreams), add a
    dictionary mapping the name of the download to a lambda function which
    transform the file provided by upstream into a dictionary of hashes,
    keyed by architecture.

commit a761623
Author: Max Gautier <mg@max.gautier.name>
Date:   Fri Feb 2 16:01:14 2024 +0100

    download_hash.py: generalized and data-driven

    The script is currently limited to one hardcoded URL for kubernetes
    related binaries, and a fixed set of architectures.

    The solution is three-fold:
    1. Use an url template dictionary for each download -> this allow to easily
       add support for new downloads.
    2. Source the architectures to search from the existing data
    3. Enumerate the existing versions in the data and start searching from
       the last one until no newer version is found (newer in the version
       order sense, irrespective of actual age)

commit fe60832
Author: Max Gautier <mg@max.gautier.name>
Date:   Thu Nov 23 21:13:55 2023 +0100

    Remove kubelet_node_{custom_flags,config_extra_args}

    There is no need to have an extra variables for this, just use different
    values per host (using Ansible group_vars, for example)

commit 1bc61c9
Author: Max Gautier <mg@max.gautier.name>
Date:   Thu Nov 23 17:18:47 2023 +0100

    Simplify kubelet-config template

    Remove system|kube_master_<resource>_reserved variables.
    Those variables are unnecessary because users can simply use the
    variables in group_vars if they which to differentiate control plane
    nodes from other nodes.

    Set conservative defaults for ephemeral-storage and pids for both kube
    and system reserved resources.

commit 872d717
Author: Max Gautier <mg@max.gautier.name>
Date:   Wed Sep 4 13:44:11 2024 +0200

    Add kube|system_reserved CI testing

commit 1533d40
Author: Max Gautier <mg@max.gautier.name>
Date:   Wed Sep 4 14:02:53 2024 +0200

    Fix kube_reserved_cgroups_for_service_slice

    The default value is used across kubespray but only defined in
    kubernetes/node.
    Move it to kubespray-defaults

commit 5b057c7
Author: Max Gautier <mg@max.gautier.name>
Date:   Mon Aug 26 14:53:20 2024 +0200

    Update list of admission plugins with a config file

commit d340273
Author: Max Gautier <mg@max.gautier.name>
Date:   Mon Aug 26 14:43:00 2024 +0200

    Remove special case for PodNodeSelector

    This is already handled by the previous task.

commit 47c3949
Author: Max Gautier <mg@max.gautier.name>
Date:   Mon Aug 26 14:42:04 2024 +0200

    Change plugins_needs_config list format

    Makes easier diff when adding or removing plugins.
@tico88612 tico88612 mentioned this pull request Sep 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VannTen VannTen Awaiting requested review from VannTen

@yankay yankay Awaiting requested review from yankay

Assignees

@VannTen VannTen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@janosbabik @k8s-ci-robot @VannTen @k8s-infra-cherrypick-robot