Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kubernetes] Support Kubernetes v1.32.0 with RHEL8 #11885

Merged

Conversation

yankay
Copy link
Member

@yankay yankay commented Jan 13, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:
Similar to #11862 with RHEL8 workaround.
Just skip the kubeadm system verification when the OS is RHEL8.
There are also some discussion about the #11872.

Upgrade kubernetes versions
Add hashes for kubernetes 1.32.0
Make kubernetes v1.32.0 default
Set minimum required version to Kubernetes v1.30.x
Cleanup old hashes
workaround for the RHEL8

Which issue(s) this PR fixes:

Fixes #11856

Does this PR introduce a user-facing change?:

Make kubernetes v1.32.0 default

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 13, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 13, 2025
@yankay yankay force-pushed the support-kubernetes-1.32.0-with-rhel branch 2 times, most recently from f8ae2dc to d5ad991 Compare January 13, 2025 10:38
Comment on lines 31 to 36
{% if ansible_os_family == "RedHat" and ansible_distribution_major_version == "8" %}
# Workaround for RHEL8: kernel version 4.18 is lower than Kubernetes system verification.
# Remove this when [Deprecate support for RedHat 8 family hosts](https://github.com/kubernetes-sigs/kubespray/issues/11872)
ignorePreflightErrors:
- SystemVerification
{% endif %}
Copy link
Contributor

@VannTen VannTen Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should automate this. This should be in the doc but given the potential problems, it should be an explicit decision by the users.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been changed

@yankay yankay force-pushed the support-kubernetes-1.32.0-with-rhel branch from d5ad991 to 351ba17 Compare January 13, 2025 13:41
@yankay yankay changed the title [kubernetes] Support Kubernetes v1.32.0 with RHEL8 [WIP][kubernetes] Support Kubernetes v1.32.0 with RHEL8 Jan 13, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2025
@mzaian mzaian changed the title [WIP][kubernetes] Support Kubernetes v1.32.0 with RHEL8 [kubernetes] Support Kubernetes v1.32.0 with RHEL8 Jan 13, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2025
@yankay yankay force-pushed the support-kubernetes-1.32.0-with-rhel branch from 351ba17 to 1950602 Compare January 14, 2025 01:47
@yankay
Copy link
Member Author

yankay commented Jan 14, 2025

HI @VannTen @mzaian
Would you please help to review it.

@yankay yankay force-pushed the support-kubernetes-1.32.0-with-rhel branch from 1950602 to 1596d95 Compare January 14, 2025 02:12
Copy link
Member

@tico88612 tico88612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions

docs/operating_systems/rhel.md Outdated Show resolved Hide resolved
@yankay yankay force-pushed the support-kubernetes-1.32.0-with-rhel branch 4 times, most recently from 6244669 to 50ed396 Compare January 14, 2025 07:13
docs/operating_systems/rhel.md Outdated Show resolved Hide resolved
docs/operating_systems/rhel.md Outdated Show resolved Hide resolved
@yankay yankay force-pushed the support-kubernetes-1.32.0-with-rhel branch 4 times, most recently from a8861a8 to d0b2cdf Compare January 14, 2025 12:06
@yankay yankay force-pushed the support-kubernetes-1.32.0-with-rhel branch 8 times, most recently from 6ae7e0e to 9778e3e Compare January 14, 2025 12:48
@yankay
Copy link
Member Author

yankay commented Jan 14, 2025

/retest

1 similar comment
@tico88612
Copy link
Member

/retest

Signed-off-by: Kay Yan <kay.yan@daocloud.io>
@yankay yankay force-pushed the support-kubernetes-1.32.0-with-rhel branch from 9778e3e to fcfd669 Compare January 15, 2025 02:00
@mzaian mzaian requested a review from VannTen January 15, 2025 08:30
Copy link
Member

@tico88612 tico88612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mzaian, tico88612, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b104bb7 into kubernetes-sigs:master Jan 15, 2025
43 checks passed
unai-ttxu pushed a commit to unai-ttxu/kubespray that referenced this pull request Jan 23, 2025
…1885)

* [kubernetes] Support Kubernetes v1.32.0

* add workaround for RHEL8

Signed-off-by: Kay Yan <kay.yan@daocloud.io>

---------

Signed-off-by: Kay Yan <kay.yan@daocloud.io>
Co-authored-by: Mohamed Zaian <mohamedzaian@gmail.com>
unai-ttxu pushed a commit to Stratio/kubespray that referenced this pull request Jan 23, 2025
…1885)

* [kubernetes] Support Kubernetes v1.32.0

* add workaround for RHEL8

Signed-off-by: Kay Yan <kay.yan@daocloud.io>

---------

Signed-off-by: Kay Yan <kay.yan@daocloud.io>
Co-authored-by: Mohamed Zaian <mohamedzaian@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubernetes 1.32 Support
5 participants