Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixup external kube-apiserver port #4075

Merged
merged 1 commit into from
Jan 21, 2019
Merged

fixup external kube-apiserver port #4075

merged 1 commit into from
Jan 21, 2019

Conversation

mattymo
Copy link
Contributor

@mattymo mattymo commented Jan 21, 2019

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 21, 2019
@mattymo
Copy link
Contributor Author

mattymo commented Jan 21, 2019

ci check this

@k8s-ci-robot k8s-ci-robot requested review from ant31 and Atoms January 21, 2019 09:56
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 21, 2019
@mattymo mattymo requested a review from woopstar January 21, 2019 11:07
@woopstar
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattymo, woopstar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mattymo mattymo merged commit 77d31e6 into master Jan 21, 2019
LuckySB added a commit to southbridgeio/kubespray that referenced this pull request Feb 17, 2019
@LuckySB
fixup external kube-apiserver port (kubernetes-sigs#4075)
5755146
@mattymo mattymo deleted the fixup_ext_apiserver-1 branch May 21, 2019 12:43
@rptaylor rptaylor mentioned this pull request May 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ant31 ant31 Awaiting requested review from ant31

@Atoms Atoms Awaiting requested review from Atoms

@woopstar woopstar Awaiting requested review from woopstar

Assignees

@woopstar woopstar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattymo @woopstar @k8s-ci-robot