Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker 18.09.1 systemd service #4085

Merged

Conversation

chadswen
Copy link
Member

The docker-ce 18.09.1 packaging missed an After dependency on containerd in the systemd service.

Upstream PR: docker/docker-ce-packaging#290

The `docker-ce` 18.09.1 packaging missed an `After` dependency on containerd in the systemd service. Upstream PR: docker/docker-ce-packaging#290
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 22, 2019
@chadswen
Copy link
Member Author

ci check this

@k8s-ci-robot k8s-ci-robot requested review from ant31 and mirwan January 22, 2019 17:24
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chadswen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 22, 2019
@chadswen chadswen added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2019
@chadswen chadswen merged commit e6f1c4d into kubernetes-sigs:master Jan 22, 2019
@chadswen chadswen deleted the docker-systemd-after-containerd branch January 22, 2019 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants