Fix kube_hostname_override inconsistencies

[chadswen]

This takes care of some situations where hostname overrides may not be set consistently across join (kubelet) and kube proxy configurations.

Closes #4037 Closes #4036

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chadswen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [chadswen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[chadswen]

ci check this

[dannyk81]

Should this also deprecate the following patch:

kubespray/roles/win_nodes/kubernetes_patch/tasks/main.yml

Lines 10 to 35 in 69e5dee

	- name: Apply kube-proxy hostnameOverride
	block:
	- name: Copy kube-proxy daemonset hostnameOverride patch
	copy:
	src: hostnameOverride-patch.json
	dest: "{{ kubernetes_user_manifests_path }}/hostnameOverride-patch.json"
	- name: Check current command for kube-proxy daemonset
	shell: "{{bin_dir}}/kubectl --kubeconfig {{ kube_config_dir }}/admin.conf get ds kube-proxy --namespace=kube-system -o jsonpath='{.spec.template.spec.containers[0].command}'"
	register: current_kube_proxy_command
	- name: Apply hostnameOverride patch for kube-proxy daemonset
	shell: "{{bin_dir}}/kubectl --kubeconfig {{ kube_config_dir }}/admin.conf patch ds kube-proxy --namespace=kube-system --type=json -p \"$(cat hostnameOverride-patch.json)\""
	args:
	chdir: "{{ kubernetes_user_manifests_path }}"
	register: patch_kube_proxy_command
	when: not current_kube_proxy_command.stdout is search("--hostname-override=${NODE_NAME}")
	- debug: msg={{ patch_kube_proxy_command.stdout_lines }}
	when: patch_kube_proxy_command is not skipped
	- debug: msg={{ patch_kube_proxy_command.stderr_lines }}
	when: patch_kube_proxy_command is not skipped
	tags: init
	when:
	- not kube_proxy_remove

This patch is currently broken and anyway is no longer needed given what this PR does.

[chadswen]

@dannyk81 Thanks for the confirmation, I can remove that patch along with this.

[chadswen]

@dannyk81 patch removed.

[Atoms]

/lgtm

[neith00]

I just want to let you know that when using cloud_provider: aws hostnames must match AWS private DNS hostname. Otherwise kubeadm fails to join nodes.
source: https://kubernetes.io/docs/concepts/cluster-administration/cloud-providers/#node-name