Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] ansible-lint: Doesn’t need a relative path in role #4508

Closed
wants to merge 1 commit into from

Conversation

Miouge1
Copy link
Contributor

@Miouge1 Miouge1 commented Apr 11, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Fix E404 ansible-lint: Doesn’t need a relative path in role

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Miouge1
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: woopstar

If they are not already assigned, you can assign the PR to them by writing /assign @woopstar in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from ant31 and mirwan April 11, 2019 13:27
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 11, 2019
@Miouge1 Miouge1 force-pushed the ansible-lint-e404 branch from a676328 to c39e377 Compare April 11, 2019 18:08
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 11, 2019
@Miouge1 Miouge1 changed the title ansible-lint: Doesn’t need a relative path in role [WIP] ansible-lint: Doesn’t need a relative path in role Apr 12, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 12, 2019
@Miouge1 Miouge1 force-pushed the ansible-lint-e404 branch from c39e377 to 4e75404 Compare April 20, 2019 10:24
@woopstar woopstar added this to the 2.11 milestone Apr 24, 2019
@Miouge1
Copy link
Contributor Author

Miouge1 commented May 10, 2019

Closing this since @MarkusTeufelberger is doing a great job with ansible-lint already.

@Miouge1 Miouge1 closed this May 10, 2019
@MarkusTeufelberger
Copy link
Contributor

Shouldn't that go in, since it seems to fix the problem? I can only make the same changes and re-commit them...

@Miouge1
Copy link
Contributor Author

Miouge1 commented May 13, 2019

The thing is this didn't pass CI, so I am not really sure how to continue about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants