Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proxy_env calculation to reset.yml #6558

Merged
merged 1 commit into from
Aug 21, 2020
Merged

Add proxy_env calculation to reset.yml #6558

merged 1 commit into from
Aug 21, 2020

Conversation

floryut
Copy link
Member

@floryut floryut commented Aug 20, 2020

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fixes running reset.yml with http_proxy enabled.

Which issue(s) this PR fixes:
Fixes #6527, expands #5896

Special notes for your reviewer:
Cherry pick of #6530
Kudos to @jcaesar

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 20, 2020
@k8s-ci-robot k8s-ci-robot requested review from bozzo and holmsten August 20, 2020 06:45
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 20, 2020
@woopstar
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, woopstar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0c80d3d into kubernetes-sigs:master Aug 21, 2020
@floryut floryut mentioned this pull request Aug 21, 2020
Closed
k8s-ci-robot pushed a commit that referenced this pull request Sep 17, 2020
@ahmadalli @floryut @nniehoff
[2.13] add missing 'Set up proxy environment' tasks (#6591)
f4b6bce 
* Add proxy_env calculation to reset.yml (#6558)

* * add proxy_env definition to remove_node.yml resolving #6430 (#6431)

Co-authored-by: Florian Ruynat <florian234@hotmail.com>
Co-authored-by: nniehoff <github@nickniehoff.net>
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jan 10, 2021
@floryut @LuckySB
Add proxy_env calculation to reset.yml (kubernetes-sigs#6558)
c1bc72d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bozzo bozzo Awaiting requested review from bozzo

@holmsten holmsten Awaiting requested review from holmsten

Assignees

@woopstar woopstar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reset.yml may fail because no_proxy is not set
3 participants
@floryut @woopstar @k8s-ci-robot