Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old note related to offline installation #7429

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

oomichi
Copy link
Contributor

@oomichi oomichi commented Apr 1, 2021

What type of PR is this?

/kind cleanup
/kind documentation

What this PR does / why we need it:

The PR #6927 has been merged and the issue #6233 was fixed.
This removes unnecessary note for the above PR.

Does this PR introduce a user-facing change?:

NONE

The PR kubernetes-sigs#6927 has been
merged and the issue kubernetes-sigs#6233
was fixed.
This removes unnecessary note for the above PR.
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 1, 2021
@k8s-ci-robot k8s-ci-robot requested review from bozzo and EppO April 1, 2021 18:14
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2021
@champtar
Copy link
Contributor

champtar commented Apr 2, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 2, 2021
@k8s-ci-robot k8s-ci-robot merged commit af1e16b into kubernetes-sigs:master Apr 2, 2021
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Apr 6, 2021
The PR kubernetes-sigs#6927 has been
merged and the issue kubernetes-sigs#6233
was fixed.
This removes unnecessary note for the above PR.
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
The PR kubernetes-sigs#6927 has been
merged and the issue kubernetes-sigs#6233
was fixed.
This removes unnecessary note for the above PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants