Remove comparison of kubelet_shutdown_grace_period and kubelet_shutdown_grace_period_critical_pods

[cristicalin]

…

What type of PR is this?

/kind bug

What this PR does / why we need it:
This PR removes the comparison of kubelet_shutdown_grace_period to kubelet_shutdown_grace_period_critical_pods because ansible cannot do time interval comparisons sanely so we defer to the better judgement of the deployer.

Which issue(s) this PR fixes:

Fixes #7991

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Remove comparison of `kubelet_shutdown_grace_period` and `kubelet_shutdown_grace_period_critical_pods` /!\ [ADD NOTE]

[k8s-ci-robot]

Hi @cristicalin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[champtar]

Those fields are golang durations, so we need to compare 2m and 30s. I would just remove the check.

[cristicalin]

The check seems useful to me to avoid deployers shooting themselves in the foot.

I added some more details to the description in the sample so its clear kubespray does extra validation and can get confused if the unit of measure is different between the two.

[cristicalin]

Sadly, you cannot massage ansible into doing sane calculations with time intervals and doing more complex data transformations would add too much code. In the end @champtar 's solution is the sanest.

[floryut]

Agreed, seems like complicated, cluster admin should be careful
/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[oomichi]

/lgtm