-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix kubespray flatcar ansible_os_family and ansible_distribution #8029
Fix kubespray flatcar ansible_os_family and ansible_distribution #8029
Conversation
Closes kubernetes-sigs#8028 Signed-off-by: Iago Santos <iago.santos.pardo@adfinis.com>
Welcome @isantospardo! |
Hi @isantospardo. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@bmelbourne any insights ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
based on https://kubernetes.slack.com/archives/C2V9WJSJD/p1632837263149500?thread_ts=1632828756.143500&cid=C2V9WJSJD I'm inclined to approve.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, isantospardo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Could we move forward with this? |
/lgtm |
…ernetes-sigs#8029) Closes kubernetes-sigs#8028 Signed-off-by: Iago Santos <iago.santos.pardo@adfinis.com>
…ernetes-sigs#8029) Closes kubernetes-sigs#8028 Signed-off-by: Iago Santos <iago.santos.pardo@adfinis.com>
…ernetes-sigs#8029) Closes kubernetes-sigs#8028 Signed-off-by: Iago Santos <iago.santos.pardo@adfinis.com>
…ernetes-sigs#8029) Closes kubernetes-sigs#8028 Signed-off-by: Iago Santos <iago.santos.pardo@adfinis.com>
…ernetes-sigs#8029) Closes kubernetes-sigs#8028 Signed-off-by: Iago Santos <iago.santos.pardo@adfinis.com>
Closes #8028
What type of PR is this?
/kind bug
What this PR does / why we need it:
Compatibility with all flatcar verions as
ansible_os_family
andansible_distribution
are set to Flatcar instead of to Flatcar Container Linux by Kinvolk for several versionsWhich issue(s) this PR fixes:
Fixes #8028
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE