Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics-server Deployment has incongruencies in resources requests/limits #8088

Merged
merged 2 commits into from
Oct 27, 2021
Merged

Metrics-server Deployment has incongruencies in resources requests/limits #8088

merged 2 commits into from
Oct 27, 2021

Conversation

irizzant
Copy link
Contributor

@irizzant irizzant commented Oct 15, 2021 •
edited by floryut
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fixes incongruence between metrics-server resources limits/requests defined in https://github.com/kubernetes-sigs/kubespray/blob/master/roles/kubernetes-apps/metrics_server/defaults/main.yml and the ones in that are effectively deployed in the cluster.

Which issue(s) this PR fixes:

Fixes #8087

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fixes incongruence between metrics-server resources limits/requests defined in official templates

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 15, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @irizzant. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 15, 2021
@irizzant irizzant changed the title fix(metrics-server): update defaults Metrics-server Deployment has incongruencies in resources requests/limits Oct 15, 2021
@irizzant
Copy link
Contributor Author

/assign @mirwan

floryut
floryut approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 27, 2021
@floryut
Copy link
Member

floryut commented Oct 27, 2021

/cc @oomichi @EppO

@k8s-ci-robot k8s-ci-robot requested a review from EppO October 27, 2021 07:31
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, irizzant

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2021
@oomichi
Copy link
Contributor

oomichi commented Oct 27, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2021
@k8s-ci-robot k8s-ci-robot merged commit 649f962 into kubernetes-sigs:master Oct 27, 2021
@irizzant irizzant deleted the issue_8087 branch October 28, 2021 07:12
@floryut floryut mentioned this pull request Dec 21, 2021
Closed
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@irizzant @sakuraiyuta
Metrics-server Deployment has incongruencies in resources requests/li…
a5ac313 
…mits (kubernetes-sigs#8088)

* fix(metrics-server): update defaults

* fix(metrics-server): typo error
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 27, 2023
@irizzant @LuckySB
Metrics-server Deployment has incongruencies in resources requests/li…
bca71c0 
…mits (kubernetes-sigs#8088)

* fix(metrics-server): update defaults

* fix(metrics-server): typo error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@holmsten holmsten Awaiting requested review from holmsten

@oomichi oomichi Awaiting requested review from oomichi

@EppO EppO Awaiting requested review from EppO

Assignees

@oomichi oomichi

@mirwan mirwan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metrics server deployment not updated
5 participants
@irizzant @k8s-ci-robot @floryut @oomichi @mirwan