Replace path_join to support Ansible 2.9

[zhengtianbao]

What type of PR is this?

/kind bug

What this PR does / why we need it:

The path_join filter is not support in ansible-base 2.9, we should use community.general.path_join instead.

refer: https://docs.ansible.com/ansible/latest/collections/community/general/docsite/filter_guide.html#paths

Which issue(s) this PR fixes:

Fixes #8159

Special notes for your reviewer:

revert this commit when the requirement of Ansible upgrade to 2.10+

Does this PR introduce a user-facing change?:

Replace path_join (in reset role) to support Ansible 2.9

[k8s-ci-robot]

Hi @zhengtianbao. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cristicalin]

Thank you for spotting this!

/ok-to-test
/lgtm

[jayonlau]

/lgtm

[floryut]

Nice, thanks for spotting that.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, zhengtianbao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cristicalin]

it seems that with ansible 2.9 we still have a failure see: https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/1765318353#L3678

TASK [reset | include file with reset tasks specific to the network_plugin if exists] ***
task path: /builds/kargo-ci/kubernetes-sigs-kubespray/roles/reset/tasks/main.yml:376
Tuesday 09 November 2021  18:19:00 +0000 (0:00:00.823)       0:01:21.835 ****** 
fatal: [instance-1]: FAILED! => {"msg": "template error while templating string: no filter named 'community.general.path_join'. String: {{ (role_path,'../network_plugin',kube_network_plugin,'tasks/reset.yml') | community.general.path_join | realpath  }}"}
PLAY RECAP *********************************************************************
instance-1                 : ok=23   changed=12   unreachable=0    failed=1    skipped=33   rescued=0    ignored=0   

[zhengtianbao]

It's weird, I've test in my environment. The difference is in my env installed ansible 2.9.6 and CI runs 2.9.27. And I upgrade my env to ansible 2.9.27, then raise the same error.

I suppose it's Ansible Community restructure the ansible/ansible repository, modules and plugins migrated to collection repositories, but this should happend at 2.10

We can use below command install the community modules at version >=2.9.8 to solve this error:

ansible-galaxy collection install community.general:=2.5.7

or:

How about implement the join_path filter by ourselves, then we can ignore the version compatible problem, I'd like to do it.

[cristicalin]

I fixed this in #8172 by adding a step to fetch the relevant collections, I assumed as you did that the filter would be part of the base collections but it does appear that ansible messed up the distribution for a point release.

[zhengtianbao]

Thanks for your precise test @cristicalin 👍 👍