Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tolerations / nodeselector / affinity to cert-manager #8389

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Add tolerations / nodeselector / affinity to cert-manager #8389

merged 1 commit into from
Jan 11, 2022

Conversation

cyril-corbon
Copy link
Contributor

@cyril-corbon cyril-corbon commented Jan 7, 2022 •
edited by oomichi
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:
add tolerations / nodeselector / affinity to all cert-manager's deployments

Which issue(s) this PR fixes:

Fixes #8356

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add the ability to set tolerations (`cert_manager_tolerations`), nodeselector (`cert_manager_nodeselector`) and affinity (`cert_manager_affinity`) in cert-manager templates

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 7, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @cyril-corbon. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 7, 2022
@k8s-ci-robot k8s-ci-robot requested review from EppO and jayonlau January 7, 2022 19:25
@cyril-corbon cyril-corbon force-pushed the fix/add-tolerations-cert-manager branch 2 times, most recently from 678875a to 7404423 Compare January 7, 2022 19:32
@cyril-corbon
fix: add tolerations / affinity to cert-manager
d9ea88e 
Signed-off-by: Cyril Corbon <corboncyril@gmail.com>
@cyril-corbon cyril-corbon force-pushed the fix/add-tolerations-cert-manager branch from 7404423 to d9ea88e Compare January 9, 2022 10:47
@cristicalin
Copy link
Contributor

Thanks for this contribution @cyril-corbon !

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 11, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2022
@oomichi
Copy link
Contributor

oomichi commented Jan 11, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyril-corbon, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit 86953b2 into kubernetes-sigs:master Jan 11, 2022
@floryut floryut added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed kind/bug Categorizes issue or PR as related to a bug. labels Jan 11, 2022
@floryut floryut changed the title fix: add tolerations / nodeselector / affinity to cert-manager Add tolerations / nodeselector / affinity to cert-manager Jan 11, 2022
@rtsp rtsp mentioned this pull request Apr 5, 2022
Merged
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@cyril-corbon @sakuraiyuta
fix: add tolerations / affinity to cert-manager (kubernetes-sigs#8389)
5c12645 
Signed-off-by: Cyril Corbon <corboncyril@gmail.com>
@oomichi oomichi added the kind/feature Categorizes issue or PR as related to a new feature. label May 28, 2022
@oomichi oomichi mentioned this pull request May 28, 2022
Closed
edmoha
edmoha reviewed May 25, 2023
View reviewed changes
roles/kubernetes-apps/ingress_controller/cert_manager/templates/cert-manager.yml.j2
Comment on lines +954 to +965
{% if cert_manager_tolerations %}
tolerations:
{{ cert_manager_tolerations | to_nice_yaml(indent=2) | indent(width=8) }}
{% endif %}
{% if cert_manager_nodeselector %}
nodeSelector:
{{ cert_manager_nodeselector | to_nice_yaml | indent(width=8) }}
{% endif %}
{% if cert_manager_affinity %}
affinity:
{{ cert_manager_affinity | to_nice_yaml | indent(width=8) }}
{% endif %}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this block needs to be moved below the next block, since using both cert_manager_trusted_internal_ca and one of these 3 options causes volumeMounts to become a key under the wrong branch (it should be under containers above).

Just ran into this issue, thought I'd post it here in case anyone wants to check or fix it.

LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 29, 2023
@cyril-corbon @LuckySB
fix: add tolerations / affinity to cert-manager (kubernetes-sigs#8389)
d658560 
Signed-off-by: Cyril Corbon <corboncyril@gmail.com>
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 20, 2023
@cyril-corbon @LuckySB
fix: add tolerations / affinity to cert-manager (kubernetes-sigs#8389)
ddda365 
Signed-off-by: Cyril Corbon <corboncyril@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmoha edmoha edmoha left review comments

@EppO EppO Awaiting requested review from EppO

@jayonlau jayonlau Awaiting requested review from jayonlau

Assignees

@cristicalin cristicalin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cert-manager tolerations
6 participants
@cyril-corbon @k8s-ci-robot @cristicalin @oomichi @edmoha @floryut