Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptive Kube-ovn #8454

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Adaptive Kube-ovn #8454

merged 1 commit into from
Jan 27, 2022

Conversation

chenhuazhong
Copy link
Contributor

@chenhuazhong chenhuazhong commented Jan 20, 2022

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

The network plug-in kube-ovn does not require a cluster to allocate podcidr

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[kube-ovn] The network plug-in kube-ovn does not require a cluster to allocate podcidr

@linux-foundation-easycla
Copy link

CLA Not Signed

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 20, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @chenhuazhong!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 20, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @chenhuazhong. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 20, 2022
@k8s-ci-robot k8s-ci-robot requested review from EppO and oomichi January 20, 2022 14:07
@linux-foundation-easycla
Copy link

CLA Not Signed

@cristicalin
Copy link
Contributor

Hi @chenhuazhong , would you mind providing some more explanation on this capability and/or link to the kube-ovn docs explaining why this works?

Also could you make sure to sign the CLA so we can accept this contribution?

@chenhuazhong
Copy link
Contributor Author

Hi @chenhuazhong , would you mind providing some more explanation on this capability and/or link to the kube-ovn docs explaining why this works?

Also could you make sure to sign the CLA so we can accept this contribution?

This is the kube-ovn documentation :https://github.com/kubeovn/kube-ovn ,kube-ovn is assigned ip by the controller, this ip can appear on any node of the cluster, rather than a cidr per node. kube-ovn can create a subnet with a 24-bit mask, but if kubeadm sets a 24-bit subnet, the node will not be able to allocate podcidr.

@chenhuazhong
Copy link
Contributor Author

I signed it

@chenhuazhong chenhuazhong force-pushed the master branch 2 times, most recently from 5cb49cf to ae05884 Compare January 25, 2022 14:49
@cristicalin
Copy link
Contributor

@chenhuazhong please rebase your branch to the most recent master to avoid the CI issues

@chenhuazhong
Copy link
Contributor Author

I signed it

@chenhuazhong
Copy link
Contributor Author

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 26, 2022
@chenhuazhong
Copy link
Contributor Author

@chenhuazhong please rebase your branch to the most recent master to avoid the CI issues

@cristicalin The rebase of the latest master branch code has been completed and the cla has been signed. This is the first time I have raised PR for the CNCF project. Please point out what is not done well.

@cristicalin
Copy link
Contributor

Looks good now, thanks @chenhuazhong !

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 26, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2022
@floryut floryut added the kind/network Network section in the release note label Jan 27, 2022
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chenhuazhong Thanks 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenhuazhong, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2022
@k8s-ci-robot k8s-ci-robot merged commit 52f221f into kubernetes-sigs:master Jan 27, 2022
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@oomichi oomichi mentioned this pull request May 28, 2022
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 29, 2023
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/network Network section in the release note lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants