Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed quotation at nerdctl_extra_flags. #8695

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Removed quotation at nerdctl_extra_flags. #8695

merged 1 commit into from
Apr 8, 2022

Conversation

T-Eberle
Copy link
Contributor

@T-Eberle T-Eberle commented Apr 8, 2022 •
edited by floryut
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:
The quotations in the variable nerdctl_extra_flags are not required for the nerdctl_image_pull_command and throw the following error when executing the cluster-playbook with container_insecure_registries set:
unknown flag: --insecure-registry\\\"
This happens as the complete nerdctl_image_pull_command variable gets split into an array string for the cmd task. The escaped quotation doesn't get escaped properly and is added to the cmd-string array as part of the command. This leads to a wrong written insecure-registry flag, which throws this error.

Which issue(s) this PR fixes:

Fixes #8689

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Removed quotation at nerdctl_extra_flags

@T-Eberle
Removed quotation of nerdctl_extra_flags.
a842499 
The quotations in the variable nerdctl_extra_flags are not required for the `nerdctl_image_pull_command` and throw the following error when executing the cluster-playbook with `container_insecure_registries` set:
        unknown flag: --insecure-registry\\\"
This happens as the complete nerdctl_image_pull_command string variable gets split into an array string for the cmd task. The escaped quotation doesn't get escaped properly and is added to the cmd-string array as part of the command. This leads to a wrong written insecure-registry flag, which throws this error.
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 8, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 8, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: T-Eberle / name: Thomas Eberle (a842499)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 8, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @T-Eberle!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @T-Eberle. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 8, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 8, 2022
floryut
floryut approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@T-Eberle 👍
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, T-Eberle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2022
@oomichi
Copy link
Contributor

oomichi commented Apr 8, 2022

Thanks for doing this @T-Eberle

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit 00a4d2d into kubernetes-sigs:master Apr 8, 2022
@oomichi oomichi mentioned this pull request Apr 8, 2022
Merged
@cristicalin cristicalin mentioned this pull request Apr 11, 2022
Closed
Quehenr pushed a commit to Quehenr/unstable-laboratory-infrastructure-kubespray that referenced this pull request Apr 14, 2022
Merge branch 'master' into feature/virtualbox
da2c785 
* master: (21 commits)
  Add tz to kubespray image
  Add tag to AWS VPC subnets for automatic subnet discovery by load balancers or ingress controllers (kubernetes-sigs#8705)
  Enable external CA mode for control-plane deployment (kubernetes-sigs#8620)
  UpCloud integration (kubernetes-sigs#8653)
  Fixes for Hetzner terraform and Hetzner Cloud  (kubernetes-sigs#8702)
  Add VAGRANT_ANSIBLE_TAGS for normal deployment (kubernetes-sigs#8697)
  Removed quotation of nerdctl_extra_flags. (kubernetes-sigs#8695)
  [calico] add calico apiserver (kubernetes-sigs#8690)
  Add support for kube-vip (kubernetes-sigs#8669)
  Ensure all Kubelet required kernel values are configured when enabling protectKernelDefaults (kubernetes-sigs#8692)
  [cert-manager] Upgrade to v1.8.0 (kubernetes-sigs#8688)
  fix: reset docker was not removing docker properly (kubernetes-sigs#8680)
  Single quotes are missing in jsonpath argument of kubectl get node (kubernetes-sigs#8683)
  split kube_feature_gates variable for different kubernetes components (kubernetes-sigs#8677)
  [crun] upgrade to 1.4.4 (kubernetes-sigs#8675)
  [validate-container-engine] check if kubelet is present was not working (kubernetes-sigs#8679)
  [containerd] upgrade versions to address CVE-2022-24769 (kubernetes-sigs#8671)
  [vsphere_csi] update to 2.5.1 and make external_vsphere_version 7.0u1 by default (kubernetes-sigs#8676)
  [runc] upgrade to 1.1.1 (kubernetes-sigs#8674)
  [nerdctl] upgrade to 0.18.0 (kubernetes-sigs#8672)
  ...
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@T-Eberle @sakuraiyuta
Removed quotation of nerdctl_extra_flags. (kubernetes-sigs#8695)
f25319b 
The quotations in the variable nerdctl_extra_flags are not required for the `nerdctl_image_pull_command` and throw the following error when executing the cluster-playbook with `container_insecure_registries` set:
        unknown flag: --insecure-registry\\\"
This happens as the complete nerdctl_image_pull_command string variable gets split into an array string for the cmd task. The escaped quotation doesn't get escaped properly and is added to the cmd-string array as part of the command. This leads to a wrong written insecure-registry flag, which throws this error.
@oomichi oomichi mentioned this pull request May 28, 2022
Closed
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 29, 2023
@T-Eberle @LuckySB
Removed quotation of nerdctl_extra_flags. (kubernetes-sigs#8695)
e55249c 
The quotations in the variable nerdctl_extra_flags are not required for the `nerdctl_image_pull_command` and throw the following error when executing the cluster-playbook with `container_insecure_registries` set:
        unknown flag: --insecure-registry\\\"
This happens as the complete nerdctl_image_pull_command string variable gets split into an array string for the cmd task. The escaped quotation doesn't get escaped properly and is added to the cmd-string array as part of the command. This leads to a wrong written insecure-registry flag, which throws this error.
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 23, 2023
@T-Eberle @LuckySB
Removed quotation of nerdctl_extra_flags. (kubernetes-sigs#8695)
3bfdc0d 
The quotations in the variable nerdctl_extra_flags are not required for the `nerdctl_image_pull_command` and throw the following error when executing the cluster-playbook with `container_insecure_registries` set:
        unknown flag: --insecure-registry\\\"
This happens as the complete nerdctl_image_pull_command string variable gets split into an array string for the cmd task. The escaped quotation doesn't get escaped properly and is added to the cmd-string array as part of the command. This leads to a wrong written insecure-registry flag, which throws this error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@cristicalin cristicalin Awaiting requested review from cristicalin

@jayonlau jayonlau Awaiting requested review from jayonlau

Assignees

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Useless" escaped quotations in the variable nerdctl_extra_flags
4 participants
@T-Eberle @k8s-ci-robot @oomichi @floryut