Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update verbs for volumeattachments resource #8731

Merged
merged 3 commits into from
Apr 22, 2022
Merged

Update verbs for volumeattachments resource #8731

merged 3 commits into from
Apr 22, 2022

Conversation

moule3053
Copy link
Contributor

@moule3053 moule3053 commented Apr 19, 2022 •
edited by floryut
Loading

Update verbs for volumeattachments resource so that the kubelet can create volumeattachments and mount volumes when deploying Kubernetes on VMware vSphere.

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes ##8730

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update verbs for volumeattachments resource

@moule3053
Update verbs for volumeattachments resource
9e9b755 
Update verbs for volumeattachments resource so that the kubelet can create volumeattachments and mount volumes when deploying Kubernetes on VMware vSphere.
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 19, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 19, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: moule3053 / name: Mulugeta Ayalew Tamiru (9e9b755)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 19, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @moule3053!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @moule3053. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 19, 2022
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 19, 2022
oomichi
oomichi reviewed Apr 19, 2022
View reviewed changes
Copy link
Contributor

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @oomichi

roles/kubernetes-apps/csi_driver/vsphere/templates/vsphere-csi-controller-rbac.yml.j2 Outdated
@@ -40,7 +40,7 @@ rules:
verbs: ["get", "list", "watch"]
- apiGroups: ["storage.k8s.io"]
resources: ["volumeattachments"]
verbs: ["get", "list", "watch", "patch"]
verbs: ["get", "list", "watch", "create", "update", "delete", "patch"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/3a71f97f4dd61e770ddc4d6492f3e4d9522907b1/manifests/guestcluster/1.22/pvcsi.yaml#L45-L46
the upstream manifest is

resources: ["volumeattachments"]
verbs: ["get", "list", "watch", "update", "patch"]

So I guess it would be fine to add "update" only.
Isn't it enough for fixing the issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @oomichi I guess it could work. Unfortunately, I don't have access anymore to the vSphere environment to test.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, how about adding "update" only for syncing to the upstream vsphere-csi-driver?
If you still face the issue, we would update the upstream manifest first, then the change will be able to be applied after that.
Through this process, we can get good technical feedback from vsphere-csi-driver maintainers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oomichi That sounds good.

@k8s-ci-robot k8s-ci-robot requested a review from oomichi April 19, 2022 16:07
@moule3053
Update verbs for volumeattachments resource
98d6e41 
Update verbs for volumeattachments resource to match upstream
@moule3053
Update vsphere-csi-controller-rbac.yml.j2
672ff20
@oomichi
Copy link
Contributor

oomichi commented Apr 21, 2022

Thanks for updating.
This makes the manifest sync to the upstream one.

/ok-to-test
/lgtm

BTW now CI is broken, but this change doesn't seem to bring any issue to the Kubespray deployment.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 21, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 21, 2022
floryut
floryut approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating. This makes the manifest sync to the upstream one.

/ok-to-test /lgtm

BTW now CI is broken, but this change doesn't seem to bring any issue to the Kubespray deployment.

Agreed, approving this one 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, moule3053

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3f06591 into kubernetes-sigs:master Apr 22, 2022
@oomichi oomichi mentioned this pull request May 28, 2022
Closed
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 30, 2023
@moule3053 @LuckySB
Update verbs for volumeattachments resource (kubernetes-sigs#8731)
c27164d 
* Update verbs for volumeattachments resource

Update verbs for volumeattachments resource so that the kubelet can create volumeattachments and mount volumes when deploying Kubernetes on VMware vSphere.

* Update verbs for volumeattachments resource

Update verbs for volumeattachments resource to match upstream

* Update vsphere-csi-controller-rbac.yml.j2
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 23, 2023
@moule3053 @LuckySB
Update verbs for volumeattachments resource (kubernetes-sigs#8731)
7b264b9 
* Update verbs for volumeattachments resource

Update verbs for volumeattachments resource so that the kubelet can create volumeattachments and mount volumes when deploying Kubernetes on VMware vSphere.

* Update verbs for volumeattachments resource

Update verbs for volumeattachments resource to match upstream

* Update vsphere-csi-controller-rbac.yml.j2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@alijahnas alijahnas Awaiting requested review from alijahnas

@LuckySB LuckySB Awaiting requested review from LuckySB

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@moule3053 @k8s-ci-robot @oomichi @floryut