Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UpCloud server plan, firewall, load balancer integration #8758

Merged
merged 3 commits into from
May 11, 2022
Merged

UpCloud server plan, firewall, load balancer integration #8758

merged 3 commits into from
May 11, 2022

Conversation

Ajarmar
Copy link
Contributor

@Ajarmar Ajarmar commented Apr 28, 2022 •
edited by floryut
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:

  1. Add support for using UpCloud's preconfigured server plans instead of having to use custom cpu/mem for servers
  2. Add support for using UpCloud's firewalls for IP allowlisting SSH access and master API access
  3. Change UpCloud Terraform provider version from 2.0.0 to 2.4.0 and add support for using their managed load balancers

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add option to use UpCloud's preconfigured server plans, firewalls and managed load balancers (upgrade to 2.4.0 from 2.0.0)

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 28, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @Ajarmar. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 28, 2022
@cristicalin
Copy link
Contributor

Hi @Ajarmar ! Thanks for this contribution.

To fix the unrelated packet job failure please ensure to rebase your code off of the latest master branch.

Also please address the linting issue selected by terraform fmt on the upload job.

cristicalin
cristicalin requested changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@cristicalin cristicalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above.

@Ajarmar Ajarmar force-pushed the upcloud-firewall-etc branch 2 times, most recently from e853ec4 to c3ac891 Compare April 29, 2022 12:03
@Ajarmar Ajarmar requested a review from cristicalin April 29, 2022 13:28
@cristicalin
Copy link
Contributor

@Ajarmar please rebase this PR on the state of the latest master branch to pick up CI fixes.

@Ajarmar Ajarmar force-pushed the upcloud-firewall-etc branch from c3ac891 to faffb94 Compare May 10, 2022 11:09
@Ajarmar
Copy link
Contributor Author

Ajarmar commented May 10, 2022

@cristicalin Sorry about that, I've rebased it now.

@oomichi
Copy link
Contributor

oomichi commented May 10, 2022

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 10, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2022
@cristicalin
Copy link
Contributor

@Ajarmar 👍

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ajarmar, cristicalin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit b9e5b0c into kubernetes-sigs:master May 11, 2022
robinAwallace pushed a commit to elastisys/kubespray that referenced this pull request May 19, 2022
@Ajarmar @robinAwallace
UpCloud server plan, firewall, load balancer integration (kubernetes-…
448b464 
…sigs#8758)

* [upcloud] add option to use preconfigured cpu/mem plan

* [upcloud] add option to use firewall rules for API server/SSH access

* [upcloud] add option to use managed load balancer
@oomichi oomichi mentioned this pull request May 28, 2022
Closed
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 30, 2023
@Ajarmar @LuckySB
UpCloud server plan, firewall, load balancer integration (kubernetes-…
4c40bc1 
…sigs#8758)

* [upcloud] add option to use preconfigured cpu/mem plan

* [upcloud] add option to use firewall rules for API server/SSH access

* [upcloud] add option to use managed load balancer
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 23, 2023
@Ajarmar @LuckySB
UpCloud server plan, firewall, load balancer integration (kubernetes-…
c83e18d 
…sigs#8758)

* [upcloud] add option to use preconfigured cpu/mem plan

* [upcloud] add option to use firewall rules for API server/SSH access

* [upcloud] add option to use managed load balancer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EppO EppO Awaiting requested review from EppO

@cristicalin cristicalin Awaiting requested review from cristicalin

Assignees

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ajarmar @k8s-ci-robot @cristicalin @oomichi