Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional setting for ca data in auth webhook #8777

Merged
merged 2 commits into from
May 5, 2022
Merged

Add optional setting for ca data in auth webhook #8777

merged 2 commits into from
May 5, 2022

Conversation

dlouks
Copy link
Contributor

@dlouks dlouks commented May 3, 2022 •
edited by floryut
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it: This adds an optional variable to include certificate-authority-data to the webhook-token-auth-config

Which issue(s) this PR fixes:

Fixes #8775

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
Allow to specify CA data for webhooks

Allow to specify CA data for webhooks (using `kube_webhook_token_auth_url_skip_tls_verify` / `kube_webhook_token_auth`)

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 3, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @dlouks. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from EppO and oomichi May 3, 2022 15:02
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 3, 2022
cristicalin
cristicalin reviewed May 3, 2022
View reviewed changes
roles/kubernetes/control-plane/defaults/main/main.yml Outdated
@@ -118,6 +118,7 @@ kube_webhook_token_auth_url_skip_tls_verify: false
kube_webhook_authorization: false
## Variables for webhook token authz https://kubernetes.io/docs/reference/access-authn-authz/webhook/
# kube_webhook_authorization_url: https://...
# kube_webhook_token_auth_ca_data:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to add this to the sample inventory file and add some description + sample formatted data.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add this. Would you recommend adding it to sample/group_vars/all/all.yml?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems like a good place, yes

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 4, 2022
@dlouks dlouks force-pushed the auth-webhook-add-ca-data branch from 71ebb30 to 27fff95 Compare May 4, 2022 16:11
@oomichi
Copy link
Contributor

oomichi commented May 5, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 5, 2022
@cristicalin
Copy link
Contributor

Thanks for doing this @dlouks !

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2022
@oomichi
Copy link
Contributor

oomichi commented May 5, 2022

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlouks, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3e52a0d into kubernetes-sigs:master May 5, 2022
@oomichi oomichi mentioned this pull request May 28, 2022
Closed
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 30, 2023
@dlouks @LuckySB
Add optional setting for ca data in auth webhook (kubernetes-sigs#8777)
6400fde 
* Add optional setting for ca data in auth webhook

* add webhook token auth variables to sample inventory
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 23, 2023
@dlouks @LuckySB
Add optional setting for ca data in auth webhook (kubernetes-sigs#8777)
19d1d2c 
* Add optional setting for ca data in auth webhook

* add webhook token auth variables to sample inventory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristicalin cristicalin cristicalin left review comments

@EppO EppO Awaiting requested review from EppO

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@oomichi oomichi

@cristicalin cristicalin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for certificate-authority-data in auth webhook
4 participants
@dlouks @k8s-ci-robot @oomichi @cristicalin